Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Update the Task Lifecycle Status chart #24133

Merged
merged 4 commits into from
Nov 7, 2024

Conversation

philrenaud
Copy link
Contributor

  • Now using Helios for component styles
  • Added colour/border styles to indicate when a task is failed, running, pending, complete, or dead/never-started

Screenshot 2024-10-04 at 4 16 41 PM
Screenshot 2024-10-04 at 4 16 19 PM

(formerly looked like this:)
image

@philrenaud
Copy link
Contributor Author

A few quick notes for reviewers: This chart shows up in two places: on a Task Group page and on an Allocation page.

You may notice a few conditionals like this.taskState?.prop — taskStates are only passed in for the Allocation version of this chart (where these lifecycle hooks can be said to represent an actual running task, and therefore get links, a singular status, etc.) as opposed to on task group pages (where the chart is a map of the configuration of lifecycles, in other words, the map but not the territory)

The pending/shimmer effect is borrowed from the job status/deployments panel

Copy link

github-actions bot commented Oct 4, 2024

Ember Test Audit comparison

main 28c062a change
passes 1581 1577 -4
failures 0 4 +4
flaky 0 0 0
duration 12m 02s 580ms 000ms -12m 02s 580ms

Copy link
Member

@schmichael schmichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic!

@philrenaud philrenaud added this to the 1.9.x milestone Oct 7, 2024
@philrenaud philrenaud force-pushed the b-ui/NET-10697-surface-which-pre-post-task-failed branch from fd10a44 to 28c062a Compare October 7, 2024 20:57
@philrenaud philrenaud added the backport/1.9.x backport to 1.9.x release line label Nov 7, 2024
@philrenaud philrenaud merged commit 3d90038 into main Nov 7, 2024
20 of 22 checks passed
@philrenaud philrenaud deleted the b-ui/NET-10697-surface-which-pre-post-task-failed branch November 7, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.9.x backport to 1.9.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants