[ui] "Clone and Edit" functionality for versions #24168
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philrenaud
force-pushed
the
24156-ui-versions-revert-version-improvements
branch
from
e2f0119
to
eaed41d
Compare
Ember Test Audit comparison
|
|
@philrenaud when this is merged, we also need to update the screenshots, and possibly text, in the job versions guide. |
philrenaud
force-pushed
the
24156-ui-versions-revert-version-improvements
branch
from
d180359
to
a5d6f63
Compare
philrenaud
changed the title
philrenaud
force-pushed
the
24156-ui-versions-revert-version-improvements
branch
from
a100fba
to
af31960
Compare
…rroring on sourceless clone
…e one you're editing, suggest they might want to run a new one instead
philrenaud
force-pushed
the
24156-ui-versions-revert-version-improvements
branch
from
af31960
to
97d3f8c
Compare
tgross
approved these changes
Nov 11, 2024
| } | ||
|
|
||
| @action async cloneAsNewJob() { | ||
| console.log('cloneAsNewJob'); |
There was a problem hiding this comment.
Debris from debugging, I think?
Suggested change
| console.log('cloneAsNewJob'); |
| specification = specificationResponse?.Source ?? null; | ||
| variableFlags = specificationResponse?.VariableFlags ?? null; | ||
| variableLiteral = specificationResponse?.Variables ?? null; | ||
| format = specificationResponse?.Format ?? 'json'; | ||
| console.log({ specification, variableFlags, variableLiteral, format }); |
Comment on lines
+9
to
+14
| {{#if (and this.sourceString (not this.disregardNameWarning))}} | ||
| <Hds::Alert @type="inline" @color="warning" data-test-job-name-warning as |A|> | ||
| <A.Title>Don't forget to change the job name!</A.Title> | ||
| <A.Description>Since you're cloning a job version's source as a new job, you'll want to change the job name. Otherwise, this will appear as a new version of the original job, rather than a new job.</A.Description> | ||
| </Hds::Alert> | ||
| {{/if}} |
There was a problem hiding this comment.
It might be nice to swap out the job name with an empty string to prevent accidental overwrites. Unfortunately we don't a JS parser for HCL2. My first pass at a regexp was something like ^job\s+"(.*)"\s+\{ but some quick testing finds some corner cases, so maybe that's not such a good idea after all. If you've got an obvious way to do this, I'd go for it, otherwise we can skip.
| @@ -501,6 +501,8 @@ module('Unit | Adapter | Job', function (hooks) { | |||
| assert.equal(request.method, 'GET'); | |||
| }); | |||
|
|
|||
| // TODO: test that version requests work for fetchRawDefinition | |||
There was a problem hiding this comment.
Do we want to resolve this TODO in this PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds "Clone and Edit" alongside "Revert Version" on the Versions page:
There are two functional paths here:
In each of these cases, we also have a split on "fetchRawDefinition" (fetches the submitted HCL or JSON jobspec) or "fetchRawSpecification" (the pre-1.5 Nomad way of getting job details, which the UI falls back to if submission/definition is not available). A lot of the duplicate-looking code in this PR is to address both paths.
Similarly, there are some safeguards included in this PR for things like ensuring users who clone to a new job change the job's name, lest it adds it as a new version unintentionally.
Because we're passing template strings via query params, this means you can use
?sourceString=on the jobs run page to send someone a readily-editable job spec, using a URL like this.This also adds a few UX conveniences like prompting a user to "run as a new job instead" if they try updating a job definition and changing its name (which fails a plan request), and reminding them to change the job name in the event they try to clone as a new one
Resolves #24156