Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow scaling system jobs to 0 #24363

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Allow scaling system jobs to 0 #24363

wants to merge 13 commits into from

Commits on Nov 8, 2024

  1. func: remove validation scaling for system jobs and dont canonicalize… 

    … to 1
    @Juanadelacuesta
    Juanadelacuesta committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    63220c8 View commit details
    Browse the repository at this point in the history

  2. test: update test to validate for 0 and improve error message

    @Juanadelacuesta
    Juanadelacuesta committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    6f5a2b0 View commit details
    Browse the repository at this point in the history

  3. func: remove the canonicalization to 1 from system jobs

    @Juanadelacuesta
    Juanadelacuesta committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    af568b0 View commit details
    Browse the repository at this point in the history

  4. docs: add changelog

    @Juanadelacuesta
    Juanadelacuesta committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    aae71d8 View commit details
    Browse the repository at this point in the history

  5. func: add test for scaling system jobs

    @Juanadelacuesta
    Juanadelacuesta committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    2917d48 View commit details
    Browse the repository at this point in the history

  6. temp: add logging to debug test

    @Juanadelacuesta
    Juanadelacuesta committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    e81aa48 View commit details
    Browse the repository at this point in the history

  7. fix: clean up after test is done

    @Juanadelacuesta
    Juanadelacuesta committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    186bcf7 View commit details
    Browse the repository at this point in the history

  8. fix: scaled down jobs will still have the stop allocation, update tes… 

    …t to account for it
    @Juanadelacuesta
    Juanadelacuesta committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    215746a View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Update the e2e test to accomodate for system jobs to have an alloc pe… 

    …r node
    @Juanadelacuesta
    Juanadelacuesta committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    77bf227 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. fix: filter to only count ready nodes on the node count

    @Juanadelacuesta
    Juanadelacuesta committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    f6ee8bb View commit details
    Browse the repository at this point in the history

  2. fix: remove the datacenter constrain from the system job definition

    @Juanadelacuesta
    Juanadelacuesta committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    a91726b View commit details
    Browse the repository at this point in the history

  3. fix: compare alloc IDs to avoid flaky tests when verifying no alloc w… 

    …as stoped
    @Juanadelacuesta
    Juanadelacuesta committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    194d4e9 View commit details
    Browse the repository at this point in the history

  4. fix: remove duplicated code

    @Juanadelacuesta
    Juanadelacuesta committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    2e99c71 View commit details
    Browse the repository at this point in the history