Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter to ignore backport PRs #12688

Closed
wants to merge 1 commit into from

Conversation

nywilken
Copy link
Contributor

@nywilken nywilken commented Nov 8, 2023

No description provided.

@nywilken nywilken requested a review from a team as a code owner November 8, 2023 19:43
@nywilken nywilken added the tech-debt Issues and pull requests related to addressing technical debt or improving the codebase label Nov 8, 2023
Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script only uses the commits' message to look for merge commits, I think we can do better than that nowadays, especially with the gh command-line tool.

I had written a script to get the PRs since the last release, I presume we could adapt it to work with this?

NOTE: this is kinda required since we don't merge every PR with merge commits, but instead we merge most by rebasing/squashing

@nywilken
Copy link
Contributor Author

nywilken commented Nov 8, 2023

NOTE: this is kinda required since we don't merge every PR with merge commits, but instead we merge most by rebasing/squashing

Ah that explains why not all the PRs are showing up

@nywilken
Copy link
Contributor Author

nywilken commented Nov 8, 2023

I will close this PR and I can circle back with your script.

@nywilken nywilken closed this Nov 8, 2023
Copy link

github-actions bot commented Dec 9, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tech-debt Issues and pull requests related to addressing technical debt or improving the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants