Backport of Document process for registering a plugin as a Packer Integration into stable-website

.github/ISSUE_TEMPLATE/plugin_integration.md

@@ -0,0 +1,21 @@
+---
+name: Plugin Integration Request
+about: Open request to add your plugin as a Packer integration (https://developer.hashicorp.com/packer/integrations)
+labels: integration-request
+---
+
+#### Description
+
+A written description of your plugin along with a link to the plugin repository. 
+
+#### Integration Tier
+<!--- By default all integrations are registered as community integrations.
+HashiCorp Technology partners https://www.hashicorp.com/partners/find-a-partner will be registered as a partner once verified. --->
+
+#### Checklist
+- [] Has valid [`metadata.hcl`](https://github.com/hashicorp/integration-template) file in plugin repository.
+- [] Has added integration scripts [packer-plugin-scaffolding](https://github.com/hashicorp/packer-plugin-scoffolding) to plugin repository.
+- [] Has added top-level integration README.md file to plugin `docs` directory.
+- [] All plugins components have one README.md describing their usage.
+- [] Has a fully synced `.web-docs` directory ready for publishing to the integrations portal.
+

CHANGELOG.md

@@ -1,6 +1,22 @@
-## 1.9.0 (Unreleased)
+## 1.9.2 (Upcoming)
+
+## 1.9.1 (June 1, 2023)
+
+### BUG FIXES:
+
+* On May 16th 2023, HCP introduced multi-project support to the platform.
+    In order to use multiple projects in your organization, you will need to update Packer
+    to version 1.9.1 or above. Starting with 1.9.1, you may specify a project ID to push
+    builds to with the `HCP_PROJECT_ID` environment variable. If no project ID is specified,
+    Packer will pick the project with the oldest creation date. Older versions of Packer are
+    incompatible with multi-project support on HCP, and builds will fail for HCP
+    organizations with multiple projects on versions before 1.9.1.
+    [GH-12453](https://github.com/hashicorp/packer/pull/12453)
+
+## 1.9.0 (May 31, 2023)
 
 ### NOTES:
+
 * **Breaking Change**: Iteration fingerprints used to be computed from the Git SHA of the
      repository where the template is located when running packer build. This
      changes with this release, and now fingerprints are automatically generated
@@ -12,20 +28,60 @@
      these builds will work exactly as they did before.
      [GH-12172](https://github.com/hashicorp/packer/pull/12172)
 
+* **Breaking Change**: Community-maintained plugins bundled with the Packer binary have been removed.
+     These external plugin components are released independently of Packer core and can be installed
+     directly by the user. Users relying on the external plugin components listed below should refer
+     to the `packer plugins` sub-command and, if using HCL2, a `required_plugins` block to define a
+     list of plugins for building a template.
+
 ### PLUGINS
+
 * Remove provisioner plugins for Chef, Converge, Puppet, Salt, and Inspec as
      vendored plugins. These plugins have been previously archived and not
      updated in release since being archived. These plugins can be installed
      using `packer init` or with the Packer plugins sub-command `packer plugins install github.com/hashicorp/chef`.
      [GH-12374](https://github.com/hashicorp/packer/pull/12374)
 
+* The following community plugins won't be bundled with Packer anymore:
+
+    * [Alicloud](https://github.com/hashicorp/packer-plugin-alicloud)
+    * [CloudStack](https://github.com/hashicorp/packer-plugin-cloudstack)
+    * [HCloud](https://github.com/hashicorp/packer-plugin-hcloud)
+    * [HyperOne](https://github.com/hashicorp/packer-plugin-hyperone)
+    * [Hyper-V](https://github.com/hashicorp/packer-plugin-hyperv)
+    * [JDCloud](https://github.com/hashicorp/packer-plugin-jdcloud)
+    * [LXC](https://github.com/hashicorp/packer-plugin-lxc)
+    * [LXD](https://github.com/hashicorp/packer-plugin-lxd)
+    * [NCloud](https://github.com/hashicorp/packer-plugin-ncloud)
+    * [OpenStack](https://github.com/hashicorp/packer-plugin-openstack)
+    * [Proxmox](https://github.com/hashicorp/packer-plugin-proxmox)
+    * [TencentCloud](https://github.com/hashicorp/packer-plugin-tencentcloud)
+    * [Triton](https://github.com/hashicorp/packer-plugin-triton)
+    * [Yandex](https://github.com/hashicorp/packer-plugin-yandex)
+
+    [GH-12436](https://github.com/hashicorp/packer/pull/12436)
+
+Users relying on these external plugin components should refer to the `packer plugins` sub-command and,
+if using HCL2, a `required_plugins` block to define a list of plugins to use for building a template.
+
 ### IMPROVEMENTS:
 
 * core/hcp: Now, fingerprints used by HCP Packer are randomly generated ULIDs
      instead of a Git SHA, and a new one is always generated, unless one is
-     already specified in the environment.
+     specified in the environment.
      [GH-12172](https://github.com/hashicorp/packer/pull/12172)
 
+### BUG FIXES:
+
+* Fix LDFLAGS for release pipelines: Between Packer 1.8.5 and Packer 1.8.7, changes
+    to the LDFLAGS in use for building the binaries for Packer had mistakenly
+    removed some compilation flags, leading to the final binaries not being stripped.
+    This change raised the size of the built binaries by as much as 45%.
+    In this release, we fixed the LDFLAGS during compilation, yielding leaner binaries.
+
+* Bumped gopsutil to v3. This fixes a macOS intermittent crash reported by the community
+    [GH-12430](https://github.com/hashicorp/packer/issues/12430)
+
 ## 1.8.7 (May 4, 2023)
 
 ### NOTES:

command/vendored_plugins.go

@@ -32,8 +32,6 @@ import (
 	googlecomputebuilder "github.com/hashicorp/packer-plugin-googlecompute/builder/googlecompute"
 	googlecomputeexportpostprocessor "github.com/hashicorp/packer-plugin-googlecompute/post-processor/googlecompute-export"
 	googlecomputeimportpostprocessor "github.com/hashicorp/packer-plugin-googlecompute/post-processor/googlecompute-import"
-	parallelsisobuilder "github.com/hashicorp/packer-plugin-parallels/builder/parallels/iso"
-	parallelspvmbuilder "github.com/hashicorp/packer-plugin-parallels/builder/parallels/pvm"
 	qemubuilder "github.com/hashicorp/packer-plugin-qemu/builder/qemu"
 	vagrantbuilder "github.com/hashicorp/packer-plugin-vagrant/builder/vagrant"
 	vagrantpostprocessor "github.com/hashicorp/packer-plugin-vagrant/post-processor/vagrant"
@@ -69,8 +67,6 @@ var VendoredBuilders = map[string]packersdk.Builder{
 	"azure-dtl":           new(azuredtlbuilder.Builder),
 	"docker":              new(dockerbuilder.Builder),
 	"googlecompute":       new(googlecomputebuilder.Builder),
-	"parallels-iso":       new(parallelsisobuilder.Builder),
-	"parallels-pvm":       new(parallelspvmbuilder.Builder),
 	"qemu":                new(qemubuilder.Builder),
 	"vagrant":             new(vagrantbuilder.Builder),
 	"vsphere-clone":       new(vsphereclonebuilder.Builder),

go.mod

@@ -59,11 +59,11 @@ require (
 )
 
 require (
+	github.com/go-openapi/strfmt v0.21.3
 	github.com/hashicorp/packer-plugin-ansible v1.0.3
 	github.com/hashicorp/packer-plugin-azure v1.4.0
 	github.com/hashicorp/packer-plugin-docker v1.0.8
 	github.com/hashicorp/packer-plugin-googlecompute v1.1.0
-	github.com/hashicorp/packer-plugin-parallels v1.0.3
 	github.com/hashicorp/packer-plugin-qemu v1.0.9
 	github.com/hashicorp/packer-plugin-vagrant v1.0.3
 	github.com/hashicorp/packer-plugin-virtualbox v1.0.4
@@ -127,7 +127,6 @@ require (
 	github.com/go-openapi/jsonreference v0.20.0 // indirect
 	github.com/go-openapi/loads v0.21.2 // indirect
 	github.com/go-openapi/spec v0.20.8 // indirect
-	github.com/go-openapi/strfmt v0.21.3 // indirect
 	github.com/go-openapi/swag v0.22.3 // indirect
 	github.com/go-openapi/validate v0.22.1 // indirect
 	github.com/gofrs/uuid v4.0.0+incompatible // indirect

go.sum

@@ -457,8 +457,6 @@ github.com/hashicorp/packer-plugin-docker v1.0.8 h1:UWPG/pl+1RFsaNQVhEuowCeOZuES
 github.com/hashicorp/packer-plugin-docker v1.0.8/go.mod h1:4U3gHULbUw3okSqqZgQZD5ptyJKs0S7LfOOt2U3V4Jk=
 github.com/hashicorp/packer-plugin-googlecompute v1.1.0 h1:/cSZCJuRV6osaSa1uOy8cpN+c/uiCbrSsZ8vyNC0slk=
 github.com/hashicorp/packer-plugin-googlecompute v1.1.0/go.mod h1:k7MhKwEDw9ASP3a1y1syKJFZiZ8pO4oH40HvVgGHzUE=
-github.com/hashicorp/packer-plugin-parallels v1.0.3 h1:smypphUCEj3arCdlvbNtZvGC1ujsUSRtN1MBvZHt/w8=
-github.com/hashicorp/packer-plugin-parallels v1.0.3/go.mod h1:Q842nvosVmP5FnYozk8ZZj93HGIan19jHTxGeteBCb0=
 github.com/hashicorp/packer-plugin-qemu v1.0.9 h1:1YKBBzBULYUBWtpAZJTbaLjjZPAdQ63okkpTqMBTnzM=
 github.com/hashicorp/packer-plugin-qemu v1.0.9/go.mod h1:BpWIpVpOoPFV9Ppmzq4DP/S0QNoh1R+7DUCqxHdXc+Y=
 github.com/hashicorp/packer-plugin-sdk v0.4.0 h1:UyLYe0y02D9wkOQ3FeeZWyFg2+mx2vLuWRGUL5xt50I=

internal/hcp/api/client.go

@@ -6,10 +6,14 @@ package api
 
 import (
 	"fmt"
+	"log"
+	"os"
+	"time"
 
 	packerSvc "github.com/hashicorp/hcp-sdk-go/clients/cloud-packer-service/stable/2021-04-30/client/packer_service"
 	organizationSvc "github.com/hashicorp/hcp-sdk-go/clients/cloud-resource-manager/preview/2019-12-10/client/organization_service"
 	projectSvc "github.com/hashicorp/hcp-sdk-go/clients/cloud-resource-manager/preview/2019-12-10/client/project_service"
+	"github.com/hashicorp/hcp-sdk-go/clients/cloud-resource-manager/preview/2019-12-10/models"
 	rmmodels "github.com/hashicorp/hcp-sdk-go/clients/cloud-resource-manager/preview/2019-12-10/models"
 	"github.com/hashicorp/hcp-sdk-go/httpclient"
 	"github.com/hashicorp/packer/internal/hcp/env"
@@ -97,9 +101,54 @@ func (c *Client) loadProjectID() error {
 	if err != nil {
 		return fmt.Errorf("unable to fetch project id: %v", err)
 	}
-	if len(listProjResp.Payload.Projects) > 1 {
-		return fmt.Errorf("this version of Packer does not support multiple projects")
+
+	if env.HasProjectID() {
+		proj, err := findProjectByID(os.Getenv(env.HCPProjectID), listProjResp.Payload.Projects)
+		if err != nil {
+			return err
+		}
+
+		c.ProjectID = proj.ID
+	} else {
+		if len(listProjResp.Payload.Projects) > 1 {
+			log.Printf("[WARNING] Multiple HCP projects found, will pick the oldest one by default\n" +
+				"To specify which project to use, set the HCP_PROJECT_ID environment variable to the one you want to use.")
+		}
+
+		proj, err := findOldestProject(listProjResp.Payload.Projects)
+		if err != nil {
+			return err
+		}
+
+		c.ProjectID = proj.ID
 	}
-	c.ProjectID = listProjResp.Payload.Projects[0].ID
+
 	return nil
 }
+
+func findOldestProject(projs []*models.HashicorpCloudResourcemanagerProject) (*models.HashicorpCloudResourcemanagerProject, error) {
+	if len(projs) == 0 {
+		return nil, fmt.Errorf("no project found")
+	}
+
+	proj := projs[0]
+	for i := 1; i < len(projs); i++ {
+		nxtProj := projs[i]
+
+		if time.Time(nxtProj.CreatedAt).Before(time.Time(proj.CreatedAt)) {
+			proj = nxtProj
+		}
+	}
+
+	return proj, nil
+}
+
+func findProjectByID(projID string, projs []*models.HashicorpCloudResourcemanagerProject) (*models.HashicorpCloudResourcemanagerProject, error) {
+	for _, proj := range projs {
+		if proj.ID == projID {
+			return proj, nil
+		}
+	}
+
+	return nil, fmt.Errorf("No project %q found", projID)
+}

internal/hcp/api/client_test.go

@@ -0,0 +1,163 @@
+package api
+
+import (
+	"testing"
+	"time"
+
+	"github.com/go-openapi/strfmt"
+	"github.com/hashicorp/hcp-sdk-go/clients/cloud-resource-manager/preview/2019-12-10/models"
+)
+
+func TestFindProjectID(t *testing.T) {
+	testcases := []struct {
+		Name            string
+		ProjectID       string
+		ProjectList     []*models.HashicorpCloudResourcemanagerProject
+		ExpectProjectID string
+		ExpectErr       bool
+	}{
+		{
+			"Only one project, project exists, success",
+			"test-project-exists",
+			[]*models.HashicorpCloudResourcemanagerProject{
+				{
+					ID: "test-project-exists",
+				},
+			},
+			"test-project-exists",
+			false,
+		},
+		{
+			"Multiple projects, project exists, success",
+			"test-project-exists",
+			[]*models.HashicorpCloudResourcemanagerProject{
+				{
+					ID: "other-project-exists",
+				},
+				{
+					ID: "test-project-exists",
+				},
+			},
+			"test-project-exists",
+			false,
+		},
+		{
+			"One project, no id match, fail",
+			"test-project-exists",
+			[]*models.HashicorpCloudResourcemanagerProject{
+				{
+					ID: "other-project-exists",
+				},
+			},
+			"",
+			true,
+		},
+		{
+			"Multiple projects, no id match, fail",
+			"test-project-exists",
+			[]*models.HashicorpCloudResourcemanagerProject{
+				{
+					ID: "other-project-exists",
+				},
+				{
+					ID: "yet-another-project-exists",
+				},
+			},
+			"",
+			true,
+		},
+		{
+			"No projects, no id match, fail",
+			"test-project-exists",
+			[]*models.HashicorpCloudResourcemanagerProject{},
+			"",
+			true,
+		},
+	}
+
+	for _, tt := range testcases {
+		t.Run(tt.Name, func(t *testing.T) {
+			proj, err := findProjectByID(tt.ProjectID, tt.ProjectList)
+			if (err != nil) != tt.ExpectErr {
+				t.Errorf("test findProjectByID, expected %t, got %t",
+					tt.ExpectErr,
+					err != nil)
+			}
+
+			if proj != nil && proj.ID != tt.ExpectProjectID {
+				t.Errorf("expected to select project %q, got %q", tt.ExpectProjectID, proj.ID)
+			}
+		})
+	}
+}
+
+func TestFindOldestProject(t *testing.T) {
+	testcases := []struct {
+		Name            string
+		ProjectList     []*models.HashicorpCloudResourcemanagerProject
+		ExpectProjectID string
+		ExpectErr       bool
+	}{
+		{
+			"Only one project, project exists, success",
+			[]*models.HashicorpCloudResourcemanagerProject{
+				{
+					ID: "test-project-exists",
+				},
+			},
+			"test-project-exists",
+			false,
+		},
+		{
+			"Multiple projects, pick the oldest",
+			[]*models.HashicorpCloudResourcemanagerProject{
+				{
+					ID:        "test-project-exists",
+					CreatedAt: strfmt.DateTime(time.Date(2023, 1, 1, 1, 0, 0, 0, time.UTC)),
+				},
+				{
+					ID:        "test-oldest-project",
+					CreatedAt: strfmt.DateTime(time.Date(2022, 1, 1, 1, 0, 0, 0, time.UTC)),
+				},
+			},
+			"test-oldest-project",
+			false,
+		},
+		{
+			"Multiple projects, different order, pick the oldest",
+			[]*models.HashicorpCloudResourcemanagerProject{
+				{
+					ID:        "test-oldest-project",
+					CreatedAt: strfmt.DateTime(time.Date(2022, 1, 1, 1, 0, 0, 0, time.UTC)),
+				},
+				{
+					ID:        "test-project-exists",
+					CreatedAt: strfmt.DateTime(time.Date(2023, 1, 1, 1, 0, 0, 0, time.UTC)),
+				},
+			},
+			"test-oldest-project",
+			false,
+		},
+		{
+			"No projects, should error",
+			[]*models.HashicorpCloudResourcemanagerProject{},
+			"",
+			true,
+		},
+	}
+
+	for _, tt := range testcases {
+		t.Run(tt.Name, func(t *testing.T) {
+			proj, err := findOldestProject(tt.ProjectList)
+			if (err != nil) != tt.ExpectErr {
+				t.Errorf("test findProjectByID, expected %t, got %t",
+					tt.ExpectErr,
+					err != nil)
+			}
+
+			if proj != nil && proj.ID != tt.ExpectProjectID {
+				t.Errorf("expected to select project %q, got %q", tt.ExpectProjectID, proj.ID)
+			}
+		})
+	}
+}