Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Judith/edu web codeowners #13224

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

judithpatudith
Copy link
Contributor

Amendment to my previous change that will let education approve PRs to the documentation side navigation and redirects.

@judithpatudith judithpatudith requested a review from a team as a code owner December 9, 2024 19:22
Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @judithpatudith,

The file looks OK to me, I don't see a problem in merging this; however your PR conflicts with the current state of CODEOWNERS since I merged your PR yesterday, I'll see if I can fix this now, and merge this after.

@lbajolet-hashicorp lbajolet-hashicorp dismissed their stale review December 10, 2024 18:39

The merge-base changed after approval.

@lbajolet-hashicorp lbajolet-hashicorp merged commit 5fa87f1 into main Dec 10, 2024
11 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants