Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: ignore AWS SDK vulnerability for release #13253

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

lbajolet-hashicorp
Copy link
Contributor

The reported AWS S3 vulnerability was inherited from the go-getter module that Packer uses for downloading files from external sources.

This vulnerability only impacts S3 uploads, therefore Packer is not vulnerable itself as go-getter only downloads such blobs.

Since the change required to fix this advisory would be to bump the AWS SDK to v2, this being a major change, is not something to do lightly, so we opted to ignore this advisory for now so it doesn't block upcoming releases.

The reported AWS S3 vulnerability was inherited from the go-getter
module that Packer uses for downloading files from external sources.

This vulnerability only impacts S3 uploads, therefore Packer is not
vulnerable itself as go-getter only downloads such blobs.

Since the change required to fix this advisory would be to bump the AWS
SDK to v2, this being a major change, is not something to do lightly, so
we opted to ignore this advisory for now so it doesn't block upcoming
releases.
@lbajolet-hashicorp lbajolet-hashicorp added tech-debt Issues and pull requests related to addressing technical debt or improving the codebase dependencies Auto-pinning labels Jan 6, 2025
@lbajolet-hashicorp lbajolet-hashicorp requested a review from a team as a code owner January 6, 2025 19:44
Copy link

@dduzgun-security dduzgun-security left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 Thanks a lot for the PR

Copy link
Contributor

@JenGoldstrich JenGoldstrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty Lucas!

@lbajolet-hashicorp lbajolet-hashicorp merged commit 783d511 into main Jan 6, 2025
13 checks passed
@lbajolet-hashicorp lbajolet-hashicorp deleted the ignore_aws_sdk_vuln_release_scanner branch January 6, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Auto-pinning tech-debt Issues and pull requests related to addressing technical debt or improving the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants