Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macie2: Remove ForceNew from tags #41266

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

macie2: Remove ForceNew from tags #41266

wants to merge 5 commits into from

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Feb 6, 2025

Description

Macie2 resource tags can be updated.
Discovered while working on #41253.

TODO

The same for

  • aws_macie2_classification_job
  • aws_macie2_custom_data_identifier
  • aws_macie2_findings_filter

Relations

Closes #38778.

Output from Acceptance Testing

% [email protected] make testacc TESTARGS='-run=TestAccMacie2_serial/^Member$$' PKG=macie2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/macie2/... -v -count 1 -parallel 20  -run=TestAccMacie2_serial/^Member$ -timeout 360m -vet=off
2025/02/06 14:38:05 Initializing Terraform AWS Provider...
=== RUN   TestAccMacie2_serial
=== PAUSE TestAccMacie2_serial
=== CONT  TestAccMacie2_serial
=== RUN   TestAccMacie2_serial/Member
=== RUN   TestAccMacie2_serial/Member/invite_removed
=== RUN   TestAccMacie2_serial/Member/status
=== RUN   TestAccMacie2_serial/Member/basic
=== RUN   TestAccMacie2_serial/Member/disappears
=== RUN   TestAccMacie2_serial/Member/tags
=== RUN   TestAccMacie2_serial/Member/invitation_disable_email_notification
=== RUN   TestAccMacie2_serial/Member/invite
--- PASS: TestAccMacie2_serial (212.14s)
    --- PASS: TestAccMacie2_serial/Member (212.14s)
        --- PASS: TestAccMacie2_serial/Member/invite_removed (32.50s)
        --- PASS: TestAccMacie2_serial/Member/status (32.85s)
        --- PASS: TestAccMacie2_serial/Member/basic (19.10s)
        --- PASS: TestAccMacie2_serial/Member/disappears (16.53s)
        --- PASS: TestAccMacie2_serial/Member/tags (48.03s)
        --- PASS: TestAccMacie2_serial/Member/invitation_disable_email_notification (31.09s)
        --- PASS: TestAccMacie2_serial/Member/invite (32.03s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/macie2	217.789s

Copy link

github-actions bot commented Feb 6, 2025

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/macie2 Issues and PRs that pertain to the macie2 service. tags Pertains to resource tagging. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/macie2 Issues and PRs that pertain to the macie2 service. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_macie2_member forces replacement on changes to tags
1 participant