Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ena_srd_specification in ec2_launch_template #41367

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

christophersherman
Copy link

@christophersherman christophersherman commented Feb 12, 2025

Description

Adds support for ena_srd_specification configuration block in aws_launch_template network interfaces, enabling ENA Express settings for enhanced networking performance.

Acceptance Tests

➜  make testacc TESTARGS='-run=TestAccEC2LaunchTemplate_NetworkInterface_enaSrd' PKG=ec2

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2LaunchTemplate_NetworkInterface_enaSrd -timeout 360m -vet=off
2025/02/12 10:26:56 Initializing Terraform AWS Provider...
=== RUN   TestAccEC2LaunchTemplate_NetworkInterface_enaSrd
=== PAUSE TestAccEC2LaunchTemplate_NetworkInterface_enaSrd
=== CONT  TestAccEC2LaunchTemplate_NetworkInterface_enaSrd
--- PASS: TestAccEC2LaunchTemplate_NetworkInterface_enaSrd (46.62s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	54.135s

Release Notes

resource/aws_launch_template: Add `ena_srd_specification` support to `network_interfaces` configuration block

local testing (with screenshots)

   aws_launch_template.test will be created
  + resource "aws_launch_template" "test" {
      + arn             = (known after apply)
      + default_version = (known after apply)
      + id              = (known after apply)
      + image_id        = "ami-088b41ffb0933423f"
      + instance_type   = "m6i.8xlarge"
      + latest_version  = (known after apply)
      + name            = (known after apply)
      + name_prefix     = "ena-express-test-"
      + tags_all        = (known after apply)

      + network_interfaces {
          + device_index    = 0
          + security_groups = (known after apply)
          + subnet_id       = (known after apply)

          + ena_srd_specification {
              + ena_srd_enabled = true

              + ena_srd_udp_specification {
                  + ena_srd_udp_enabled = true
                }
            }
        }

      + tag_specifications {
          + resource_type = "instance"
          + tags          = {
              + "Name" = "ena-express-test-instance"
            }
        }
    }

   aws_launch_template.test2 will be created
  + resource "aws_launch_template" "test2" {
      + arn             = (known after apply)
      + default_version = (known after apply)
      + id              = (known after apply)
      + image_id        = "ami-088b41ffb0933423f"
      + instance_type   = "m6i.8xlarge"
      + latest_version  = (known after apply)
      + name            = (known after apply)
      + name_prefix     = "ena-express-test2-"
      + tags_all        = (known after apply)

      + network_interfaces {
          + device_index    = 0
          + security_groups = (known after apply)
          + subnet_id       = (known after apply)

          + ena_srd_specification {
              + ena_srd_enabled = true

              + ena_srd_udp_specification {
                  + ena_srd_udp_enabled = false
                }
            }
        }

      + tag_specifications {
          + resource_type = "instance"
          + tags          = {
              + "Name" = "ena-express-test-instance2"
            }
        }
    }

instance in test1
image

instance in test2
image

@christophersherman christophersherman requested a review from a team as a code owner February 12, 2025 19:16
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ec2 Issues and PRs that pertain to the ec2 service. needs-triage Waiting for first response or review from a maintainer. labels Feb 12, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @christophersherman 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants