prepared query: add missing RemoveEmptyTag and Name should be optional #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The Name field of the JSON payload should be optional, see:
https://www.consul.io/api-docs/query#name
* Add missing https://www.consul.io/api-docs/query#removeemptytags
|
Hi @ygersie, thanks for opening this PR. The API client will first need to be updated at https://github.com/hashicorp/consul before I can merge this. I will look into this. |
|
Hi @ygersie! I opened hashicorp/consul#14244 to add this to the Consul API client. Once it is merge we will be able to add support for this in the provider. |
|
@remilapeyre is there any chance this can get a push? |
|
Looks like the required changes got merged in hashicorp/consul#16113, I think this should now be doable :) |
remilapeyre
approved these changes
Jul 24, 2023
There was a problem hiding this comment.
Hi @ygersie, thanks for taking the time to make this Pull Request! It will ship in the next release :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.consul.io/api-docs/query#name