Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore changes to Status in consul_config_entry for http-route, tcp-route and api-gateway #361

Merged
merged 5 commits into from
Oct 24, 2023
Merged

Ignore changes to Status in consul_config_entry for http-route, tcp-route and api-gateway #361

merged 5 commits into from
Oct 24, 2023

Conversation

remilapeyre
Copy link
Collaborator

@remilapeyre remilapeyre commented Oct 8, 2023 •
edited
Loading

Closes #359

Also update the Consul API client to v1.25.1.

roncodingenthusiast
roncodingenthusiast approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@roncodingenthusiast roncodingenthusiast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, minor nitpicks. I think we are moving most things to hashicorp/go-metrics in general as armon/go-metrics was migrated to that so they are identical

consul/resource_consul_config_entry_ce_test.go Show resolved Hide resolved
go.mod Show resolved Hide resolved
@remilapeyre remilapeyre merged commit f55cfd9 into hashicorp:master Oct 24, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roncodingenthusiast roncodingenthusiast roncodingenthusiast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

config_entry should ignore Status key when determining diffs
2 participants
@remilapeyre @roncodingenthusiast