Add a note regarding consul_acl_token_secret_id in the consul_acl_token resource description #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en resource description
|
|
||
| ### Basic usage | ||
| ## Example Usage |
There was a problem hiding this comment.
Suggested change
| ## Example Usage | |
| ## Example usage |
the docs team is moving towards sentence style capitalization for titles so maybe we could do the same here
docs/resources/acl_token.md
Outdated
|
|
||
| The `service_identities` block supports the following arguments: | ||
| ### Read-Only |
There was a problem hiding this comment.
Suggested change
| ### Read-Only | |
| ### Read-only |
docs/resources/acl_token.md
Outdated
|
|
||
| The `node_identities` block supports the following arguments: | ||
| <a id="nestedblock--node_identities"></a> | ||
| ### Nested Schema for `node_identities` |
There was a problem hiding this comment.
Suggested change
| ### Nested Schema for `node_identities` | |
| ### Nested schema for `node_identities` |
docs/resources/acl_token.md
Outdated
| * `expiration_time` - If set this represents the point after which a token should be considered revoked and is eligible for destruction. | ||
| * `namespace` - The namespace to create the token within. | ||
| <a id="nestedblock--service_identities"></a> | ||
| ### Nested Schema for `service_identities` |
There was a problem hiding this comment.
Suggested change
| ### Nested Schema for `service_identities` | |
| ### Nested schema for `service_identities` |
roncodingenthusiast
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also migrate consul_acl_token to tfplugindocs.