Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consume latest release of ghaction-terraform-provider-release #414

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

nathancoleman
Copy link
Member

This version compensates for changes in GitHub's contract for custom runners

This version compensates for changes in GitHub's contract for custom runners
This handles the fact that #409 modified the generated docs directly instead of the source code that the docs are generated from.
Copy link
Member Author

@nathancoleman nathancoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personal review

@@ -230,7 +230,7 @@ removed during the next [anti-entropy synchronization](https://www.consul.io/doc
Type: schema.TypeString,
Optional: true,
Default: "30s",
Description: "The time after which the service is automatically deregistered when in the `critical` state. Defaults to `30s`.",
Description: "The time after which the service is automatically deregistered when in the `critical` state. Defaults to `30s`. Setting to `0` will disable.",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was causing the docs CI validation to fail due to the fact that the generated markdown was previously modified directly instead of modifying this source code and then regenerating the markdown.

Copy link
Member

@jm96441n jm96441n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathancoleman nathancoleman merged commit 88fc3f2 into main Aug 2, 2024
5 checks passed
@nathancoleman nathancoleman deleted the update-release-action branch August 2, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants