Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version resolution for empty constraints #296

Merged
merged 4 commits into from
Nov 9, 2023

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented Nov 9, 2023

This PR regenerates the Terraform version list and fixes a bug with empty constraints.

If a pre-release was at the top of the version list, we returned it instead of LatestAvailableVersion as seen in this test failure.

@dbanck dbanck added the bug Something isn't working label Nov 9, 2023
@dbanck dbanck self-assigned this Nov 9, 2023
@dbanck dbanck requested a review from a team as a code owner November 9, 2023 14:54
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in the other two conditions look good to me but the first one I think we should keep as-is.

schema/versions.go Outdated Show resolved Hide resolved
schema/versions.go Show resolved Hide resolved
Co-authored-by: Radek Simko <[email protected]>
@dbanck dbanck merged commit 0e7be2b into main Nov 9, 2023
4 checks passed
@dbanck dbanck deleted the b-fix-version-resolution branch November 9, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants