Revert convert to esm #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #533
Looks like that change has broken the action as can be seen in this comment.
Unfortunately, our E2E tests and local tests don't reveal this issue. It has something to do with the fact that they use the local path:
But I am not sure exactly why that succeeds and the following fails:
However, there is good news. (1) #533 has not been released yet and (2) It looks like there is experimental support for require()-ing synchronous ES modules in Node.js from nodejs/node#51977 which should be available in the next major node Version (v22?). That should allow us to import
gotv14 without having to convert our project to ESM.