Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bats tests run faster #502

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

benashz
Copy link
Collaborator

@benashz benashz commented Dec 6, 2023

Drop use of the yq docker image, replacing it with a binary from the project repo.

Local run:

92 tests, 0 failures

make unit-test  8.02s user 7.78s system 136% cpu 11.581 total

drop use of the yq docker image, replacing it with a binary from the
project repo.
@benashz benashz requested a review from a team as a code owner December 6, 2023 22:58
@benashz benashz changed the title Make bats run faster Make bats tests run faster Dec 6, 2023
@benashz benashz requested review from kschoche and tvoran December 6, 2023 23:40
Copy link
Contributor

@kschoche kschoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@benashz benashz merged commit 0054492 into main Dec 7, 2023
@benashz benashz deleted the VAULT-21812/make-bats-faster-drop-docker-yq branch December 7, 2023 00:53
adrianmoisey pushed a commit to adrianmoisey/vault-secrets-operator that referenced this pull request Jan 16, 2024
drop use of the yq docker image, replacing it with a binary from the
project's repo here: https://github.com/mikefarah/yq
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants