-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update storybook monorepo to v8 (major) #4792
Draft
renovate
wants to merge
8
commits into
main
Choose a base branch
from
deps/js/major-storybook-monorepo
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a95f18e
Update storybook monorepo to v8
renovate[bot] 726e571
`yarn dlx storybook@latest upgrade` update `main.js`
vilkinsons 47adfe1
`yarn dlx storybook@latest upgrade` update `package.json`
vilkinsons c22a50a
`yarn dlx storybook@latest upgrade` update `yarn.lock`
vilkinsons e335580
Try adding `@babel/preset-react`
vilkinsons d4fe1d0
Merge branch 'refs/heads/main' into deps/js/major-storybook-monorepo
TimDiekmann 87b60d8
`yarn fix`
vilkinsons 6c1c7c8
`yarn fix` pt.ii
vilkinsons File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,44 @@ | ||
| import { dirname, join } from "path"; | ||
| module.exports = { | ||
| stories: [ | ||
| "../../../libs/@hashintel/design-system/src/**/*.mdx", | ||
| "../../../libs/@hashintel/design-system/src/**/*.stories.@(js|jsx|ts|tsx)", | ||
| "../../../libs/@hashintel/block-design-system/src/**/*.mdx", | ||
| "../../../libs/@hashintel/block-design-system/src/**/*.stories.@(js|jsx|ts|tsx)", | ||
| ], | ||
|
|
||
| addons: [ | ||
| "@storybook/addon-links", | ||
| "@storybook/addon-essentials", | ||
| "@storybook/addon-interactions", | ||
| getAbsolutePath("@storybook/addon-links"), | ||
| getAbsolutePath("@storybook/addon-essentials"), | ||
| getAbsolutePath("@storybook/addon-interactions"), | ||
| "@storybook/addon-webpack5-compiler-babel", | ||
| ], | ||
|
|
||
| babel: async (options) => { | ||
| return { | ||
| ...options, | ||
| presets: [...options.presets, "@babel/preset-react"], | ||
| }; | ||
| }, | ||
|
|
||
| framework: { | ||
| name: "@storybook/react-webpack5", | ||
| name: getAbsolutePath("@storybook/react-webpack5"), | ||
| options: {}, | ||
| }, | ||
|
|
||
| core: { | ||
| disableTelemetry: true, | ||
| }, | ||
|
|
||
| docs: { | ||
| docsPage: true, | ||
| }, | ||
|
|
||
| typescript: { | ||
| reactDocgen: "react-docgen-typescript", | ||
| }, | ||
| }; | ||
|
|
||
| function getAbsolutePath(value) { | ||
| return dirname(require.resolve(join(value, "package.json"))); | ||
|
Check warning Code scanning / Semgrep PRO Semgrep Finding: javascript.lang.security.audit.path-traversal.path-join-resolve-traversal.path-join-resolve-traversal Warning
Detected possible user input going into a path.join or path.resolve function. This could possibly lead to a path traversal vulnerability, where the attacker can access arbitrary files stored in the file system. Instead, be sure to sanitize or validate user input first.
|
||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Detected possible user input going into a
path.joinorpath.resolvefunction. This could possibly lead to a path traversal vulnerability, where the attacker can access arbitrary files stored in the file system. Instead, be sure to sanitize or validate user input first.View Dataflow Graph
flowchart LR classDef invis fill:white, stroke: none classDef default fill:#e7f5ff, color:#1c7fd6, stroke: none subgraph File0["<b>apps/hashdotdesign/.storybook/main.js</b>"] direction LR %% Source subgraph Source direction LR v0["<a href=https://github.com/hashintel/hash/blob/726e5712a27dc56fc57d382121f14fd5e1715e74/apps/hashdotdesign/.storybook/main.js#L35 target=_blank style='text-decoration:none; color:#1c7fd6'>[Line: 35] value</a>"] end %% Intermediate subgraph Traces0[Traces] direction TB v2["<a href=https://github.com/hashintel/hash/blob/726e5712a27dc56fc57d382121f14fd5e1715e74/apps/hashdotdesign/.storybook/main.js#L35 target=_blank style='text-decoration:none; color:#1c7fd6'>[Line: 35] value</a>"] end %% Sink subgraph Sink direction LR v1["<a href=https://github.com/hashintel/hash/blob/726e5712a27dc56fc57d382121f14fd5e1715e74/apps/hashdotdesign/.storybook/main.js#L36 target=_blank style='text-decoration:none; color:#1c7fd6'>[Line: 36] value</a>"] end end %% Class Assignment Source:::invis Sink:::invis Traces0:::invis File0:::invis %% Connections Source --> Traces0 Traces0 --> Sink