Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H-4012: Satisfy required precondition of DNS library #6350

Merged

Conversation

indietyp
Copy link
Member

@indietyp indietyp commented Feb 4, 2025

🌟 What is the purpose of this PR?

Create the library skeletons for both the N-API library (@local/effect-dns-hickory) and core library (@local/effect-dns-core).

Tagging both Tim and Ciaran as this is both Rust and Typescript.

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • affected the execution graph, and the turbo.json's have been updated to reflect this

@indietyp indietyp self-assigned this Feb 4, 2025
@indietyp indietyp requested a review from a team as a code owner February 4, 2025 17:41
@github-actions github-actions bot added area/deps Relates to third-party dependencies (area) area/infra Relates to version control, CI, CD or IaC (area) area/libs Relates to first-party libraries/crates/packages (area) type/eng > backend Owned by the @backend team area/tests New or updated tests type/legal Owned by the @legal team labels Feb 4, 2025
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@vilkinsons
Copy link
Member

@indietyp Please tag me when test are passing for legal

libs/@local/effect-dns/hickory/package.json Show resolved Hide resolved
libs/@local/effect-dns/hickory/Cargo.toml Show resolved Hide resolved
libs/@local/effect-dns/hickory/Cargo.toml Outdated Show resolved Hide resolved
libs/@local/effect-dns/hickory/Cargo.toml Show resolved Hide resolved
libs/@local/effect-dns/hickory/Cargo.toml Outdated Show resolved Hide resolved
libs/@local/effect-dns/hickory/Cargo.toml Outdated Show resolved Hide resolved
libs/@local/effect-dns/hickory/Cargo.toml Show resolved Hide resolved
TimDiekmann
TimDiekmann previously approved these changes Feb 5, 2025
CiaranMn
CiaranMn previously approved these changes Feb 5, 2025
vilkinsons
vilkinsons previously approved these changes Feb 5, 2025
@indietyp indietyp dismissed stale reviews from vilkinsons and CiaranMn via 345e70b February 5, 2025 10:49
@indietyp indietyp added this pull request to the merge queue Feb 5, 2025
Merged via the queue into main with commit 941341c Feb 5, 2025
148 checks passed
@indietyp indietyp deleted the bm/h-4012-satisfy-required-precondition-of-dns-library-skeleton branch February 5, 2025 11:24
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Benchmark results

@rust/hash-graph-benches – Integrations

scaling_read_entity_complete_zero_depth

Function Value Mean Flame graphs
entity_by_id 25 entities $$3.40 \mathrm{ms} \pm 12.0 \mathrm{μs}\left({\color{gray}-2.476 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$2.01 \mathrm{ms} \pm 7.97 \mathrm{μs}\left({\color{gray}-1.566 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$2.03 \mathrm{ms} \pm 9.41 \mathrm{μs}\left({\color{gray}-1.885 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$2.11 \mathrm{ms} \pm 10.4 \mathrm{μs}\left({\color{lightgreen}-6.558 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 50 entities $$4.17 \mathrm{ms} \pm 19.1 \mathrm{μs}\left({\color{gray}-1.032 \mathrm{\%}}\right) $$ Flame Graph

representative_read_entity

Function Value Mean Flame graphs
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/uk-address/v/1 $$16.0 \mathrm{ms} \pm 191 \mathrm{μs}\left({\color{lightgreen}-34.440 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/person/v/1 $$15.6 \mathrm{ms} \pm 176 \mathrm{μs}\left({\color{lightgreen}-35.754 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/book/v/1 $$17.6 \mathrm{ms} \pm 226 \mathrm{μs}\left({\color{gray}4.40 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/page/v/2 $$16.3 \mathrm{ms} \pm 176 \mathrm{μs}\left({\color{gray}-4.670 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/block/v/1 $$17.1 \mathrm{ms} \pm 176 \mathrm{μs}\left({\color{red}6.31 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/song/v/1 $$16.4 \mathrm{ms} \pm 199 \mathrm{μs}\left({\color{gray}-3.887 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/organization/v/1 $$17.4 \mathrm{ms} \pm 157 \mathrm{μs}\left({\color{gray}-4.504 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/playlist/v/1 $$17.7 \mathrm{ms} \pm 187 \mathrm{μs}\left({\color{gray}0.981 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/building/v/1 $$16.6 \mathrm{ms} \pm 148 \mathrm{μs}\left({\color{lightgreen}-8.048 \mathrm{\%}}\right) $$ Flame Graph

representative_read_entity_type

Function Value Mean Flame graphs
get_entity_type_by_id Account ID: d4e16033-c281-4cde-aa35-9085bf2e7579 $$2.14 \mathrm{ms} \pm 6.30 \mathrm{μs}\left({\color{gray}-1.318 \mathrm{\%}}\right) $$ Flame Graph

representative_read_multiple_entities

Function Value Mean Flame graphs
link_by_source_by_property depths: DT=0, PT=2, ET=2, E=2 $$89.5 \mathrm{ms} \pm 418 \mathrm{μs}\left({\color{gray}0.510 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=2, E=2 $$85.1 \mathrm{ms} \pm 377 \mathrm{μs}\left({\color{gray}0.761 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=2 $$75.1 \mathrm{ms} \pm 349 \mathrm{μs}\left({\color{gray}-1.081 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=2, PT=2, ET=2, E=2 $$93.0 \mathrm{ms} \pm 266 \mathrm{μs}\left({\color{gray}0.041 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=255, PT=255, ET=255, E=255 $$102 \mathrm{ms} \pm 374 \mathrm{μs}\left({\color{gray}0.447 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=0 $$39.5 \mathrm{ms} \pm 265 \mathrm{μs}\left({\color{gray}-1.125 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=2, ET=2, E=2 $$53.6 \mathrm{ms} \pm 327 \mathrm{μs}\left({\color{gray}-3.702 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=2, E=2 $$49.0 \mathrm{ms} \pm 224 \mathrm{μs}\left({\color{gray}-2.544 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=2 $$43.7 \mathrm{ms} \pm 186 \mathrm{μs}\left({\color{gray}-1.624 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=2, PT=2, ET=2, E=2 $$56.5 \mathrm{ms} \pm 296 \mathrm{μs}\left({\color{gray}-3.997 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=255, PT=255, ET=255, E=255 $$65.4 \mathrm{ms} \pm 163 \mathrm{μs}\left({\color{gray}-3.610 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=0 $$39.5 \mathrm{ms} \pm 181 \mathrm{μs}\left({\color{gray}-3.128 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_complete_one_depth

Function Value Mean Flame graphs
entity_by_id 25 entities $$177 \mathrm{ms} \pm 703 \mathrm{μs}\left({\color{gray}-1.707 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$21.0 \mathrm{ms} \pm 82.8 \mathrm{μs}\left({\color{gray}0.325 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$27.4 \mathrm{ms} \pm 194 \mathrm{μs}\left({\color{gray}1.11 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$31.8 \mathrm{ms} \pm 140 \mathrm{μs}\left({\color{gray}-3.376 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 50 entities $$5.33 \mathrm{s} \pm 534 \mathrm{ms}\left({\color{gray}-1.336 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_linkless

Function Value Mean Flame graphs
entity_by_id 100 entities $$2.22 \mathrm{ms} \pm 9.35 \mathrm{μs}\left({\color{gray}-1.696 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1000 entities $$3.05 \mathrm{ms} \pm 16.6 \mathrm{μs}\left({\color{gray}1.49 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10000 entities $$13.5 \mathrm{ms} \pm 31.2 \mathrm{μs}\left({\color{red}27.3 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$2.01 \mathrm{ms} \pm 10.8 \mathrm{μs}\left({\color{gray}-1.415 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$2.03 \mathrm{ms} \pm 7.73 \mathrm{μs}\left({\color{gray}-1.549 \mathrm{\%}}\right) $$ Flame Graph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/deps Relates to third-party dependencies (area) area/infra Relates to version control, CI, CD or IaC (area) area/libs Relates to first-party libraries/crates/packages (area) area/tests New or updated tests type/eng > backend Owned by the @backend team type/legal Owned by the @legal team
Development

Successfully merging this pull request may close these issues.

4 participants