Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H-4048: Don't suggest ignoring a warning in vitest extension #6413

Merged

Conversation

TimDiekmann
Copy link
Member

🌟 What is the purpose of this PR?

Instead of suggesting to ignore a warning the warning should be fixed. This removes the setting from the .vscode/settings.json. Also, it adds a few other recommended settings.

Copy link
Contributor

Benchmark results

@rust/hash-graph-benches – Integrations

scaling_read_entity_complete_zero_depth

Function Value Mean Flame graphs
entity_by_id 25 entities $$3.36 \mathrm{ms} \pm 10.8 \mathrm{μs}\left({\color{gray}0.591 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$1.99 \mathrm{ms} \pm 9.93 \mathrm{μs}\left({\color{gray}0.609 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$2.00 \mathrm{ms} \pm 10.0 \mathrm{μs}\left({\color{gray}0.515 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$2.10 \mathrm{ms} \pm 8.58 \mathrm{μs}\left({\color{gray}-3.234 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 50 entities $$4.05 \mathrm{ms} \pm 22.0 \mathrm{μs}\left({\color{gray}-0.999 \mathrm{\%}}\right) $$ Flame Graph

representative_read_entity

Function Value Mean Flame graphs
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/page/v/2 $$16.1 \mathrm{ms} \pm 195 \mathrm{μs}\left({\color{lightgreen}-28.824 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/uk-address/v/1 $$16.2 \mathrm{ms} \pm 209 \mathrm{μs}\left({\color{lightgreen}-28.071 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/book/v/1 $$15.9 \mathrm{ms} \pm 202 \mathrm{μs}\left({\color{gray}-3.528 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/block/v/1 $$16.7 \mathrm{ms} \pm 166 \mathrm{μs}\left({\color{red}6.21 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/organization/v/1 $$15.9 \mathrm{ms} \pm 167 \mathrm{μs}\left({\color{gray}-4.138 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/building/v/1 $$16.3 \mathrm{ms} \pm 175 \mathrm{μs}\left({\color{gray}0.450 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/playlist/v/1 $$17.1 \mathrm{ms} \pm 187 \mathrm{μs}\left({\color{red}5.82 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/person/v/1 $$16.1 \mathrm{ms} \pm 182 \mathrm{μs}\left({\color{lightgreen}-16.031 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/song/v/1 $$16.2 \mathrm{ms} \pm 170 \mathrm{μs}\left({\color{gray}-0.451 \mathrm{\%}}\right) $$ Flame Graph

representative_read_entity_type

Function Value Mean Flame graphs
get_entity_type_by_id Account ID: d4e16033-c281-4cde-aa35-9085bf2e7579 $$2.13 \mathrm{ms} \pm 7.69 \mathrm{μs}\left({\color{gray}0.702 \mathrm{\%}}\right) $$ Flame Graph

representative_read_multiple_entities

Function Value Mean Flame graphs
link_by_source_by_property depths: DT=0, PT=2, ET=2, E=2 $$84.8 \mathrm{ms} \pm 314 \mathrm{μs}\left({\color{gray}1.01 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=2, E=2 $$79.9 \mathrm{ms} \pm 310 \mathrm{μs}\left({\color{gray}-0.860 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=2 $$72.0 \mathrm{ms} \pm 373 \mathrm{μs}\left({\color{gray}1.01 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=2, PT=2, ET=2, E=2 $$88.1 \mathrm{ms} \pm 497 \mathrm{μs}\left({\color{gray}0.206 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=255, PT=255, ET=255, E=255 $$96.5 \mathrm{ms} \pm 470 \mathrm{μs}\left({\color{gray}-0.066 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=0 $$36.8 \mathrm{ms} \pm 222 \mathrm{μs}\left({\color{gray}1.38 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=2, ET=2, E=2 $$51.9 \mathrm{ms} \pm 267 \mathrm{μs}\left({\color{gray}1.30 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=2, E=2 $$46.9 \mathrm{ms} \pm 218 \mathrm{μs}\left({\color{gray}0.303 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=2 $$41.7 \mathrm{ms} \pm 291 \mathrm{μs}\left({\color{gray}0.734 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=2, PT=2, ET=2, E=2 $$56.2 \mathrm{ms} \pm 207 \mathrm{μs}\left({\color{gray}2.57 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=255, PT=255, ET=255, E=255 $$64.4 \mathrm{ms} \pm 354 \mathrm{μs}\left({\color{gray}-0.265 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=0 $$36.9 \mathrm{ms} \pm 233 \mathrm{μs}\left({\color{gray}0.667 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_complete_one_depth

Function Value Mean Flame graphs
entity_by_id 25 entities $$82.6 \mathrm{ms} \pm 629 \mathrm{μs}\left({\color{lightgreen}-53.829 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$20.5 \mathrm{ms} \pm 41.9 \mathrm{μs}\left({\color{gray}-0.286 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$26.8 \mathrm{ms} \pm 105 \mathrm{μs}\left({\color{gray}-0.217 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$57.1 \mathrm{ms} \pm 195 \mathrm{μs}\left({\color{gray}-0.626 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 50 entities $$5.39 \mathrm{s} \pm 539 \mathrm{ms}\left({\color{gray}1.09 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_linkless

Function Value Mean Flame graphs
entity_by_id 100 entities $$2.11 \mathrm{ms} \pm 6.11 \mathrm{μs}\left({\color{gray}0.349 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1000 entities $$2.93 \mathrm{ms} \pm 11.3 \mathrm{μs}\left({\color{gray}-0.433 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10000 entities $$9.32 \mathrm{ms} \pm 89.8 \mathrm{μs}\left({\color{lightgreen}-30.696 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$2.00 \mathrm{ms} \pm 7.75 \mathrm{μs}\left({\color{gray}0.017 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$2.00 \mathrm{ms} \pm 6.22 \mathrm{μs}\left({\color{gray}-0.259 \mathrm{\%}}\right) $$ Flame Graph

Copy link
Member

@vilkinsons vilkinsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...but we should actually fix the issue. It's lingered a long time.

@TimDiekmann TimDiekmann added this pull request to the merge queue Feb 11, 2025
Merged via the queue into main with commit a960d00 Feb 11, 2025
149 checks passed
@TimDiekmann TimDiekmann deleted the t/h-4048-dont-suggest-ignoring-a-warning-in-vitest-extension branch February 11, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants