Ensure that beam-sqlite is built with sqlite-3.24+ (fixes #589)

haskell-beam · Jan 11, 2025 · 4cfd5f6 · 4cfd5f6
1 parent ea48db3
commit 4cfd5f6
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/beam-sqlite/ChangeLog.md b/beam-sqlite/ChangeLog.md
@@ -1,3 +1,9 @@
+# Unreleased
+
+## Dependencies
+
+* Ensure that beam-sqlite uses sqlite-3.24+, which is the minimum supported version (#589).
+
 # 0.5.4.0
 
 ## Added features

diff --git a/beam-sqlite/beam-sqlite.cabal b/beam-sqlite/beam-sqlite.cabal
@@ -41,7 +41,15 @@ library
                       network-uri   >=2.6  && <2.7,
                       aeson         >=0.11 && <2.3,
                       attoparsec    >=0.13 && <0.15,
-                      transformers-base    >=0.4  && <0.5
+                      transformers-base    >=0.4  && <0.5,
+                      -- Dependency on direct-sqlite is not direct,
+                      -- but functionality in beam-sqlite depends on
+                      -- a minimum version of sqlite. At this time,
+                      -- we require at least sqlite-3.24.
+                      -- Note that because of this, we cannot use the 
+                      -- `Wunused-packages` warning.
+                      -- See #589
+                      direct-sqlite >=2.3.24
   default-language:   Haskell2010
   default-extensions: ScopedTypeVariables, OverloadedStrings, MultiParamTypeClasses, RankNTypes, FlexibleInstances,
                       DeriveDataTypeable, DeriveGeneric, StandaloneDeriving, TypeFamilies, GADTs, OverloadedStrings,
@@ -50,8 +58,6 @@ library
                       -Widentities
                       -Wincomplete-uni-patterns
                       -Wincomplete-record-updates
-  if impl(ghc >= 8.10)
-    ghc-options: -Wunused-packages
   if flag(werror)
     ghc-options: -Werror