Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove direct dependence of beam-sqlite on platform-specific packages #739

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

LaurentRDC
Copy link
Member

@LaurentRDC LaurentRDC commented Jan 3, 2025

This PR removes beam-sqlite's direct dependence on either the unix or windows package, which should allow to build beam-core and beam-sqlite on a wider variety of platforms.

Fixes #738

Before merging, I want to at least manually check that beam-sqlite can be compiled using the WASM backend

…s`, allowing to build on a wider variety of platforms
@LaurentRDC LaurentRDC self-assigned this Jan 3, 2025
@dhess
Copy link

dhess commented Jan 3, 2025

Thanks for the remarkably quick turnaround on this request!

We haven't yet properly integrated beam-sqlite into our project, but I quickly added it to our project's deps so that it gets built, and I can confirm that this branch builds with the Wasm backend, using the latest version of these tools: https://gitlab.haskell.org/haskell-wasm/ghc-wasm-meta

@LaurentRDC LaurentRDC merged commit 15af356 into master Jan 3, 2025
16 checks passed
@LaurentRDC
Copy link
Member Author

Thanks for checking! I released a new version of beam-sqlite on Hackage

@dhess
Copy link

dhess commented Jan 3, 2025

Amazing, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wasm support
2 participants