FromJSON tests #465
Merged
FromJSON tests #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwiegley
requested changes
Mar 10, 2019
emmanueldenloye
force-pushed
the
fromJSONTests
branch
from
d41121f to
7e528f9
Compare
emmanueldenloye
force-pushed
the
fromJSONTests
branch
from
7e528f9 to
134bf49
Compare
|
Looking good! |
jwiegley
approved these changes
Mar 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a currently failing test which I think exposes an oversight in the JSON parser in hnix. The failing case is as follows: If there is a key which contains a string that consists of digits, such as "4275", then that key is parsed as a number instead of as a string. This causes the parsed JSON to not match the result that is parsed from nix.
This references issue #442.