Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly markup <$> in documentation of alterF #877

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

Flupp
Copy link
Contributor

@Flupp Flupp commented Nov 22, 2022

For both IntMap variants, the < and > did not appear in the haddock output.

While at it, also in the documentation for the other alterF variants the <$> was turned into a hyperlink.

Copy link
Contributor

@meooow25 meooow25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for fixing the bad Haddocks for IntMap.

While at it, also in the documentation for the other alterF variants the <$> was turned into a hyperlink.

I would prefer it if we did not do this, because the link is a bit distracting when it is not the focus of the documentation. Do you mind reverting those?

For both `IntMap` variants, the `<` and `>` did not appear in the
haddock output.
@Flupp
Copy link
Contributor Author

Flupp commented Aug 6, 2024

I thought it made the markup more uniform and might also be helpful for beginners.

Anyways, I now just added escaping where needed.

I also rebased on current master.

Copy link
Contributor

@meooow25 meooow25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@meooow25 meooow25 merged commit ddd130a into haskell:master Aug 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants