Use a relative src dir path in containers-tests instead of a symlink. #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should make working on containers easier when on windows.
|
Worked for me locally not sure why this failes on CI. |
|
Let me know when you get it working and I'll merge. |
|
Any further ideas? |
|
Best I can tell CI runs the actual testsuite by moving the container-tests folder to some other place which invalidates the I couldn't yet find the motivation to dig into the ci config. If I run into the issue again I probably will but it's not urgent for me personally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make working on containers easier when on windows.
Fixes #885