Enable Travis CI #16
Enable Travis CI #16
Conversation
* Drop support for GHC 6.12.3 and 7.4.1 * Add support for GHC 8.0.2
GHC.RTS.EventsIncremental uses Data.IntMap.Strict which requires containers >= 0.5.
|
Splendid! LGTM. |
|
I think it's better to disable write-merge for now because otherwise we have to check every travis build log to confirm nothing is actually broken. |
maoe
force-pushed
the
travis
branch
4 times, most recently
from
5a48fd3
to
b535a3f
Compare
|
Travis now skips write-merge: https://travis-ci.org/maoe/ghc-events/builds/200771369 |
|
Reworded the last commit message. s/is/are/ |
| import System.IO (IOMode(ReadMode), openBinaryFile) | ||
| import System.Exit (die) | ||
| import System.IO | ||
| import System.Exit |
There was a problem hiding this comment.
Why did you change these to non-selective imports? I see the case for System.Exit but not sure about System.IO.
There was a problem hiding this comment.
I removed the import list for System.IO.stderr, which is also used in die.
There was a problem hiding this comment.
Oh, I missed that - fair enough.
|
Only posted an insignificant question on one of the changes. Looks good! @Mikolaj: shall I merge it or do we want someone else's opinion as well? |
|
IMHO, if @simonmar doesn't object, let's merge. Great job, BTW. |
|
Right, pending on his call then. |
|
Any objections? |
|
I think you can safely assume there are none. :) |
|
Okay, could we merge then? |
|
O, you didn't have repo write access. My bad, I can actually add you. Done. |
|
Great, thank you! I'm going to merge this then. |
|
@Mikolaj Could you please enable Travis builds? I see ghc-events on https://travis-ci.org/profile/haskell but it's grayed out so I cannot enable it. |
|
Right. Supposedly it should work now. |
|
Thanks! |
|
You are welcome. |
This PR enables Travis CI with various GHC versions including the latest one.