-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for GHC < 8 #89
Conversation
Also drop related workarounds and tests that depend on this code. Strangely one of the GHC-7 tests failed as well even though the comments suggest this code is only needed for GHC-6. This isn't an issue cause we are dropping support for GHC-7 too.
@bgamari, @mpickering, @AndreasPK: since you are the only producers of ghc-events data and you keep a copy of the file .eventlog format in GHC --- do you see any obstacle to dropping compatibility with 5 years old GHCs? How could this affect your copy of the code? |
I don't use GHC < 8.0 any more so I'm personally fine with this change.
I'm interested in this remark. What issue does this change unblock specifically? |
I think I had this comment in mind #14 (comment) |
I don't think there should be issues for ghc itself in that regard. |
Thank you. In that case, even code cleanup could be reason enough. After all, maintenance takes work and hairy code makes it harder. |
I see. If that issue could be fixed by simply dropping the old GHC support as suggested, that would be great. I'm +1 to this change. I'm going to ping @simonmar as he said
in #27 in the past. Do you mind if we drop support for GHC < 8 now? |
It doesn't fix #14 unfortunately. I tried re-enabling the test suites and they still fail. I think the remaining issue is due to events being reordered because of how EventBlock is handled. |
That's unfortunate. That said, it'd still be nice to get rid of some old code along with the relevant test data for simplicity. Also there have been no objections since this was submitted almost a month ago. I think we can go ahead. |
This MR removes parsers and workarounds specific to GHC < 8.
I've also removed some test cases for older eventlogs.
Resolves #88