Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up parsing #1214

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Speed up parsing #1214

wants to merge 7 commits into from

Conversation

hasufell
Copy link
Member

Related to #1213

@hasufell hasufell mentioned this pull request Jan 15, 2025
Open
@hasufell hasufell changed the title Avoid repeated calls to 'hlsGHCVersions' Speed up parsing Jan 15, 2025
@hasufell
Copy link
Member Author

hasufell commented Jan 15, 2025 •
edited
Loading

If we merge this, then we'll have to adjust ghcup-metadata to check for well-formedness of the URLs.

@hasufell hasufell requested a review from dfordivam January 15, 2025 17:26
dfordivam
dfordivam approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@dfordivam dfordivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds ok, it does save a lot on parse on every execution of ghcup.

@hasufell
Copy link
Member Author

I got 20ms more out of it by switching back to yaml-streamly, but I'm not sure I want to go there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfordivam dfordivam dfordivam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hasufell @dfordivam