Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metadata for GHC 9.4.7 #110

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Metadata for GHC 9.4.7 #110

merged 1 commit into from
Aug 25, 2023

Conversation

wz1000
Copy link
Collaborator

@wz1000 wz1000 commented Aug 23, 2023

No description provided.

@wz1000
Copy link
Collaborator Author

wz1000 commented Aug 23, 2023

https://gitlab.haskell.org/ghc/ghcup-ci/-/pipelines/83202

@hasufell
Copy link
Member

The signatures are still invalid.

@wz1000
Copy link
Collaborator Author

wz1000 commented Aug 23, 2023

The signatures are still invalid.

haskell/ghcup-hs#873

hasufell
hasufell reviewed Aug 23, 2023
View reviewed changes
Copy link
Member

@hasufell hasufell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run the GHCup bindist pipeline. GHC CI pipelines are nit sufficient.

ghcup-0.0.7.yaml
dlHash: 415e6adebd764d278ecfe4ebf656ff96902953b8b669fba7dae2525af6665172
Linux_Alpine:
unknown_versioning:
dlUri: https://downloads.haskell.org/~ghc/9.4.7/ghc-9.4.7-x86_64-alpine3_12-linux.tar.xz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this dynamic or static?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is dynamic now, as requested in https://gitlab.haskell.org/ghc/ghc/-/issues/23828

Static bindists are quite broken.

@wz1000
Copy link
Collaborator Author

wz1000 commented Aug 23, 2023

Don't merge yet, I'm currently considering whether to backport an additional patch https://gitlab.haskell.org/ghc/ghc/-/issues/23819#note_522030

@wz1000
Copy link
Collaborator Author

wz1000 commented Aug 25, 2023

@hasufell this is ready to go, we are not going to do any additional backports https://gitlab.haskell.org/ghc/ghc/-/issues/23819#note_522346

Could you merge this and sign with your keys? We can sort out the key situation later when Ben is also around.

@wz1000
Copy link
Collaborator Author

wz1000 commented Aug 25, 2023

https://github.com/haskell/ghcup-metadata/actions/runs/5974734715

@wz1000 wz1000 merged commit 3fb3d65 into develop Aug 25, 2023
20 of 21 checks passed
@hasufell
Copy link
Member

I'm drunk. I'll look at it tomorrow. We need proper GPG signatures.

@hasufell
Copy link
Member

Why did you merge with a broken and undocumented signature?

@wz1000
Copy link
Collaborator Author

wz1000 commented Aug 25, 2023

Why did you merge with a broken and undocumented signature?

Before I merged I asked @bgamari to fix the signatures and merge develop into master.

@hasufell
Copy link
Member

Neither his or your signatures are documented. It's broken for end users.

@wz1000
Copy link
Collaborator Author

wz1000 commented Aug 25, 2023

Ben's signature is documented at https://www.haskell.org/ghcup/guide/#gpg-verification

@hasufell
Copy link
Member

Ben's signature is documented at https://www.haskell.org/ghcup/guide/#gpg-verification

That is the old expired GPG key.

@bgamari
Copy link
Collaborator

bgamari commented Aug 25, 2023

I verified the signatures before merging. for i in *.sig; do echo $i; gpg --verify $i || break; done did not reveal any problematic signatures.

@bgamari
Copy link
Collaborator

bgamari commented Aug 25, 2023 •
edited
Loading

That is the old expired GPG key.

As far as I know that key should have been renewed as of earlier this month:

$ gpg --list-keys FE5AB6C91FEA597C3B31180B73EDE9E8CFBAEF01
pub   rsa2048 2013-07-31 [SC] [expires: 2025-08-02]
      FE5AB6C91FEA597C3B31180B73EDE9E8CFBAEF01
uid           [ultimate] Benjamin Gamari <[email protected]>
uid           [ultimate] Benjamin Gamari <[email protected]>
sub   rsa2048 2016-06-22 []
sub   rsa2048 2016-06-22 [E] [expires: 2025-08-02]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasufell hasufell hasufell left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wz1000 @hasufell @bgamari