Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata on release of Stack 3.1.1 #241

Merged
merged 1 commit into from
Aug 4, 2024
Merged

Add metadata on release of Stack 3.1.1 #241

merged 1 commit into from
Aug 4, 2024

Conversation

mpilgrem
Copy link
Collaborator

I am not sure how 'Recommended' is meant to work for the vanilla channel - it that the GHCup project's decision or is it the origin's decision? From the perspective of the Stack project, the latest released version of Stack is always recommended.

@hasufell
Copy link
Member

I am not sure how 'Recommended' is meant to work for the vanilla channel - it that the GHCup project's decision or is it the origin's decision?

So far the policy was recommended == latest, but I'm fine with upstream doing the decisions.

@andreasabel
Copy link
Member

Merging is blocked
The base branch requires all commits to be signed.

@mpilgrem Do you intend to replace the commit by a signed one?

@mpilgrem
Copy link
Collaborator Author

mpilgrem commented Aug 4, 2024

@andreasabel, can you give me a pointer to what I would have to do to make a 'signed' commit? EDIT: Scratch that request, I see GitHub has an article on the subject.

@mpilgrem mpilgrem merged commit 527d381 into develop Aug 4, 2024
1 check passed
@mpilgrem mpilgrem deleted the stack-3.1.1 branch August 4, 2024 16:41
@hasufell
Copy link
Member

hasufell commented Aug 5, 2024

@mpilgrem the files themselves have to be signed with gpg too and a separate .sig file committeed, also see https://github.com/haskell/ghcup-metadata?tab=readme-ov-file#gpg-signing

@mpilgrem
Copy link
Collaborator Author

mpilgrem commented Aug 5, 2024

@hasufell, sorry if I merged prematurely, on that basis. EDIT: I see that a GHCup developer will need to sign the files that I edited.

@hasufell
Copy link
Member

hasufell commented Aug 6, 2024

@hasufell, sorry if I merged prematurely, on that basis. EDIT: I see that a GHCup developer will need to sign the files that I edited.

merging to develop is fine if it's not signed. But master has to work with ghcup --gpg Strict -s https://raw.githubusercontent.com/haskell/ghcup-metadata/master/ghcup-vanilla-0.0.8.yaml list.

I fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants