Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for 9.10 #4233

Merged
merged 94 commits into from
Jun 13, 2024
Merged

Support for 9.10 #4233

merged 94 commits into from
Jun 13, 2024

Conversation

wz1000
Copy link
Collaborator

@wz1000 wz1000 commented May 15, 2024

This includes supports for all plugins, other than formatters and hlint.

We need ghc-exactprint and retrie release before merging this.
@michaelpj
Copy link
Collaborator

If anyone wants to help, chasing up any of the allow-newers would be helpful (get upstream to release/make a revision).

@jhrcek jhrcek requested a review from eddiemundo as a code owner May 17, 2024 05:37
@michaelpj
Copy link
Collaborator

I've revised the lsp packages

@michaelpj
Copy link
Collaborator

Somehow the build is failing on macos with a weird linker error?

michaelpj added a commit that referenced this pull request Jun 12, 2024
This is an attempt to isolate changes from
#4233
in order to reproduce the mac build failure.
@michaelpj michaelpj mentioned this pull request Jun 12, 2024
@michaelpj
Copy link
Collaborator

fourmolu got released, trying to add that now

@michaelpj
Copy link
Collaborator

The plugin doesn't compile and it's not 100% obvious how to fix it, so reverting to add later.

@michaelpj
Copy link
Collaborator

I made a GHC issue for the linker problem: https://gitlab.haskell.org/ghc/ghc/-/issues/24982

It's also reproducible if we just bump the index-state: #4315

@jhrcek jhrcek requested a review from kokobd as a code owner June 13, 2024 05:23
@michaelpj michaelpj enabled auto-merge (squash) June 13, 2024 14:02
@michaelpj
Copy link
Collaborator

:shipit:

Copy link
Collaborator

@jhrcek jhrcek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelpj michaelpj merged commit 3009a45 into master Jun 13, 2024
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants