Remove networkmanager-cli from installed packages #761
+0
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe recent update to the SSH configuration Dockerfile involves the removal of the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
frenck
added
the
enhancement
Using nmcli from the SSH add-on is an unsupported way of adjusting network configuration in HA OS, and the mismatch of versions of the NetworkManager in the OS and nmcli in the add-on leads to errors that even make it impossible to use it. Having nmcli bundled in the SSH terminal add-on (even the unofficial one) makes users think this is somehow the correct and supported way of configuring advanced networking features. Remove the package from the default set of installed software. Correct way to handle network configuration in HA OS is to use `ha network` command set, and if there's any functionality missing, open feature requests for that.
frenck
approved these changes
Jul 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Using nmcli from the SSH add-on is an unsupported way of adjusting network configuration in HA OS, and the mismatch of versions of the NetworkManager in the OS and nmcli in the add-on leads to errors that even make it impossible to use it. Having nmcli bundled in the SSH terminal add-on (even the unofficial one) makes users think this is somehow the correct and supported way of configuring advanced networking features.
Remove the package from the default set of installed software. Correct way to handle network configuration in HA OS is to use
ha networkcommand set, and if there's any functionality missing, open feature requests for that.Related Issues
Just a sample of some recent ones:
Summary by CodeRabbit
networkmanager-clipackage from SSH Dockerfile to streamline the build process.