ndc-test #10
Merged
ndc-test #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e selection field is empty
src/sqlGeneration.ts
Outdated
Comment on lines
77
to
78
| if (Object.keys(fieldsToSelect).length === 0) { | ||
| return `*` |
There was a problem hiding this comment.
This is not correct. In this case we can just return VALUE {}.
There was a problem hiding this comment.
My bad. I missed it when removing extra code. Fixed it.
src/execution.ts
Outdated
Comment on lines
173
to
175
| if (sqlGenCtx.selectFields == null || sqlGenCtx.selectFields == undefined || Object.keys(sqlGenCtx.selectFields).length === 0) { | ||
| queryResponse = []; | ||
| } |
There was a problem hiding this comment.
You won't need to do this if you are run SELECT VALUE {} when fields is an empty array.
There was a problem hiding this comment.
This is returning 500 internal error saying incorrect syntax near '{
I think there should be a script to do this. Then we can call this script as part of the CI pipeline too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix errors while running
ndc-testHow to test:
/script/app.jsusingnode app.js- This will create a database, a container and add data to the emulator.connector_config_emulator.jsonfile as configuration for emulator andconnector_config.jsonfile for cloud.cargo run --bin ndc-test -- test --endpoint http://localhost:8080in ndc-spec repoor follow the Readme.md for pre-existing snapshot tests