fix/feat: primary photo auto set and auto-set primary photo (#651)

* fix error when item doesn't have photo attachment

* automatically detect image types and set primary photo if first

* remove charts.js from libs

backend/app/api/handlers/v1/v1_ctrl_items_attachments.go

@@ -3,6 +3,7 @@ package v1
 import (
 	"errors"
 	"net/http"
+	"path/filepath"
 
 	"github.com/hay-kot/homebox/backend/internal/core/services"
 	"github.com/hay-kot/homebox/backend/internal/data/ent/attachment"
@@ -67,7 +68,15 @@ func (ctrl *V1Controller) HandleItemAttachmentCreate() errchain.HandlerFunc {
 
 		attachmentType := r.FormValue("type")
 		if attachmentType == "" {
-			attachmentType = attachment.TypeAttachment.String()
+			// Attempt to auto-detect the type of the file
+			ext := filepath.Ext(attachmentName)
+
+			switch ext {
+			case ".jpg", ".jpeg", ".png", ".webp", ".gif", ".bmp", ".tiff":
+				attachmentType = attachment.TypePhoto.String()
+			default:
+				attachmentType = attachment.TypeAttachment.String()
+			}
 		}
 
 		id, err := ctrl.routeID(r)

backend/go.mod

@@ -29,7 +29,6 @@ require (
 require (
 	github.com/KyleBanks/depth v1.2.1 // indirect
 	github.com/agext/levenshtein v1.2.3 // indirect
-	github.com/apparentlymart/go-textseg/v13 v13.0.0 // indirect
 	github.com/apparentlymart/go-textseg/v15 v15.0.0 // indirect
 	github.com/davecgh/go-spew v1.1.1 // indirect
 	github.com/dustin/go-humanize v1.0.1 // indirect

backend/internal/data/repo/repo_item_attachments.go

@@ -52,11 +52,30 @@ func ToItemAttachment(attachment *ent.Attachment) ItemAttachment {
 }
 
 func (r *AttachmentRepo) Create(ctx context.Context, itemId, docId uuid.UUID, typ attachment.Type) (*ent.Attachment, error) {
-	return r.db.Attachment.Create().
+	bldr := r.db.Attachment.Create().
 		SetType(typ).
 		SetDocumentID(docId).
-		SetItemID(itemId).
-		Save(ctx)
+		SetItemID(itemId)
+
+  // Autoset primary to true if this is the first attachment
+  // that is of type photo
+  if typ == attachment.TypePhoto {
+    cnt, err := r.db.Attachment.Query().
+      Where(
+        attachment.HasItemWith(item.ID(itemId)),
+        attachment.TypeEQ(typ),
+      ).
+      Count(ctx)
+    if err != nil {
+      return nil, err
+    }
+
+    if cnt == 0 {
+      bldr = bldr.SetPrimary(true)
+    }
+  }
+
+  return bldr.Save(ctx)
 }
 
 func (r *AttachmentRepo) Get(ctx context.Context, id uuid.UUID) (*ent.Attachment, error) {
@@ -75,7 +94,7 @@ func (r *AttachmentRepo) Update(ctx context.Context, itemId uuid.UUID, data *Ite
 	bldr := r.db.Attachment.UpdateOneID(itemId).
 		SetType(typ)
 
-		// Primary only applies to photos
+	// Primary only applies to photos
 	if typ == attachment.TypePhoto {
 		bldr = bldr.SetPrimary(data.Primary)
 	} else {

backend/internal/data/repo/repo_items.go

@@ -845,6 +845,7 @@ func (e *ItemsRepository) SetPrimaryPhotos(ctx context.Context, GID uuid.UUID) (
 		Where(
 			item.HasGroupWith(group.ID(GID)),
 			item.HasAttachmentsWith(
+				attachment.TypeEQ(attachment.TypePhoto),
 				attachment.Not(
 					attachment.And(
 						attachment.Primary(true),

frontend/lib/api/classes/items.ts

@@ -28,10 +28,12 @@ export type ItemsQuery = {
 };
 
 export class AttachmentsAPI extends BaseAPI {
-  add(id: string, file: File | Blob, filename: string, type: AttachmentTypes) {
+  add(id: string, file: File | Blob, filename: string, type: AttachmentTypes | null = null) {
     const formData = new FormData();
     formData.append("file", file);
-    formData.append("type", type);
+    if (type) {
+      formData.append("type", type);
+    }
     formData.append("name", filename);
 
     return this.http.post<FormData, ItemOut>({

frontend/package.json

@@ -44,7 +44,6 @@
     "@vueuse/nuxt": "^10.0.0",
     "@vueuse/router": "^10.0.0",
     "autoprefixer": "^10.4.8",
-    "chart.js": "^4.0.1",
     "daisyui": "^2.24.0",
     "dompurify": "^3.0.0",
     "h3": "^1.7.1",
@@ -54,7 +53,6 @@
     "postcss": "^8.4.16",
     "tailwindcss": "^3.1.8",
     "vue": "^3.3.1",
-    "vue-chartjs": "^4.1.2",
     "vue-router": "4"
   }
 }