This repository has been archived by the owner on Jun 12, 2024. It is now read-only.
backend: Remove checked-in compiled binary #726
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* bump all deps * run code-gen
…t#506) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…t#508) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ay-kot#451) * Fixed 3 places where API URLs were not constructed by function route(path, params). * autofix --------- Co-authored-by: Hayden <[email protected]>
* formatting * slimdown locations page * update location/labels * fix dependency issues * fix type generator * cleanup unused variables
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* add multiple new currencies * add multiple new currencies * remove duplicate yen
…port k… (hay-kot#526) * add support for create + add more for all create modals and support keyboard bindings * listen for esc to close modals
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…busting (hay-kot#527) * rough implementation of WS based event system for server side notifications of mutation * fix test construction * fix deadlock on event bus * disable linter error * add item mutation events * remove old event bus code * refactor event system to use composables * refresh items table when new item is added * fix create form errors * cleanup unnecessary calls * fix importer erorrs + limit fn calls on import
* Added currencies XAG and XAU to currency.ts I added XAG and XAU for myself and others who prefer to measure value with something of substance. Review the ISO 4217 standard to view a full list of official currency codes including the ones I have added. https://www.iso.org/iso-4217-currency-codes.html https://en.wikipedia.org/wiki/ISO_4217 Example: https://www.xe.com/currencyconverter/convert/?Amount=100&From=XAG&To=USD API for exchange rates: https://openexchangerates.org/ * Added field values xag and xau to group.go * Update group.go
* fix https connection * explicity dependency
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* extract auth into provider * bump go version * use pointer * rebase
Co-authored-by: zebrapurring <>
* fix inaccruate 401 error on SQL db error * init golangci-lint config * linter autofix * testify auto fixes * fix sqlite busy errors * fix naming * more linter errors * fix rest of linter issues
…ay-kot#676) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…kot#673) * feat: show quantity in card view if quantity == 0 (hay-kot#672) * Update frontend/components/Item/Card.vue --------- Co-authored-by: bee-eater <[email protected]> Co-authored-by: Hayden <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Quoing <[email protected]>
* basic currency service for loading at runtime * api endpoint for currencies * sort slice before return * remove currency validation * validate using currency service * implement selecting dynamic currency options * bump go version * fix type definition * specify explicit type * change go versions * proper types for assetId * log/return currency error * make case insensative * use ToUpper instead * feat: adding new currencies (hay-kot#715) * fix: task swag (hay-kot#710) Co-authored-by: Quoing <[email protected]> * [feat] Adding new currencies --------- Co-authored-by: quoing <[email protected]> Co-authored-by: Quoing <[email protected]> Co-authored-by: Bradley <[email protected]> * remove ts file and consoldate new values into json * move flag to options namespace * add env config for currencies * basic documentaion * remove in sync test --------- Co-authored-by: quoing <[email protected]> Co-authored-by: Quoing <[email protected]> Co-authored-by: Bradley <[email protected]>
Co-authored-by: zebrapurring <>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…-kot#668) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…0.17.0 (hay-kot#717) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…-kot#723) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
LINKIWI
changed the title
|
Hey! Thanks for pointing this out, I decided to remove the binary form the git history as well so it didn't inflate the size of the repo long term. Should be good now. Closing this. Thanks again for all you recent PRs super helpful! |
|
Thanks. It seems the bot re-introduced the file in #699 (perhaps due to a bad merge?) |
|
Ugghhhhh. Nice catch thanks! Just removed it from the commit. Hopefully that's the last one :D |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
There is a compiled binary checked into the
backenddirectory, which I can only imagine was added by mistake.I am assuming
backend/apiis a path predefined as part of a local build process. So I also added a corresponding entry to.gitignoreto prevent future regressions.Which issue(s) this PR fixes:
(REQUIRED)
Fixes a large binary unintentionally versioned into the source tree.
Special notes for your reviewer:
(fill-in or delete this section)
Testing
(fill-in or delete this section)
N/A
Release Notes
(REQUIRED)