Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Backport action #23

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Conversation

JackPGreen
Copy link
Contributor

@JackPGreen JackPGreen commented Jan 22, 2025

A syntax error causes a failure to evaluate the script.

This was probably a copy-paste error introduced when copying from my test environment in #21.

I have investigated some kind of validation tool to catch this error to add to the PR builder without running the workflow but been unsuccessful.

A [syntax error causes a failure to evaluate the script](https://github.com/hazelcast/hz-docs/actions/runs/12912238050).

This was _probably_ a copy-paste error introduced when copying from my test environment in hazelcast#21
@JackPGreen JackPGreen requested a review from ldziedziul January 22, 2025 16:25
@JackPGreen JackPGreen self-assigned this Jan 22, 2025
@JackPGreen JackPGreen requested a review from nishaatr January 23, 2025 12:10
Copy link
Collaborator

@ldziedziul ldziedziul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JackPGreen
Copy link
Contributor Author

JackPGreen commented Jan 23, 2025

Could we add https://github.com/rhysd/actionlint?

Doesn't support composite actions (which is what backport is) unfortunately.

More specifically it reports errors... but they aren't actually errors.

@JackPGreen JackPGreen merged commit 6dd3bd7 into hazelcast:master Jan 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants