Updating Viridian -> Cloud #149
Conversation
Catching instances of Viridian in the cloud repo that are not covered by the variable update
rebekah-lawrence
requested review from
Serdaro and
oliverhowell
as code owners
| @@ -45,7 +45,7 @@ For a complete tutorial, see the xref:get-started.adoc[] topic. | |||
| [[advanced]] | |||
| == Configure Your Own Client | |||
|
|
|||
| You can access the information needed to connect your own clients through any of the pre-configured client details. | |||
| You can access the information needed to connect your own clients through the *Advanced* option. | |||
There was a problem hiding this comment.
| You can access the information needed to connect your own clients through the *Advanced* option. | |
| You can access the information needed to connect your own clients through the *Advanced* option. |
Is it Advanced or Advanced setup (as in steps)? Also 'using' rather than 'through'?
There was a problem hiding this comment.
It is Advanced - that's the name of the option you select.
Yes, it should be using - these changes are for the addition of the Advanced option instead of making people go through one of the pre-configured clients; my attention to detail slipped there! Good spot.
There was a problem hiding this comment.
I know it's not part of your changes but we should change the step too then - will highlight...
There was a problem hiding this comment.
Ah, maybe it's tucked up in get-connection-creds.adoc as a partial
| - Your trial environment, including all data, will be automatically deleted. | ||
| - Your trial environment, including all data, is automatically deleted. | ||
|
|
||
| Hazelcast will be in touch during your trial, and when it ends. If you want to talk further with us about subscription options, mailto:[email protected][send us an email], or select the button available at the end of most trial communications from Hazelcast. |
There was a problem hiding this comment.
| Hazelcast will be in touch during your trial, and when it ends. If you want to talk further with us about subscription options, mailto:viridian@hazelcast.com[send us an email], or select the button available at the end of most trial communications from Hazelcast. | |
| Hazelcast will be in touch during your trial, and when it ends. If you want to talk further with us about subscription options, mailto:cloud@hazelcast.com[send us an email], or select the button available at the end of most trial communications from Hazelcast. |
As above - hopefully team have the email change planned inc. redirect!
There was a problem hiding this comment.
Yes, of course I won't be merging any changes until they are ready; I just want the changes to be ready to go as I'm sure it will all happen very quickly when it happens.
| @@ -35,7 +35,7 @@ Exceeding these limits can lead to cluster failure. | |||
|
|
|||
| Be aware that the following operations use heap memory: writing, caching, or replicating data to data structures other than IMap an JCache. | |||
|
|
|||
| See xref:serverless-cluster.adoc#heap-memory-limits-of-viridian-serverless-clusters[Heap Memory Limits of {hazelcast-cloud} Standard Clusters] for further details. | |||
| For further information on {hazelcast-cloud} Standard clusters and their limits, see the xref:serverless-cluster.adoc[] topic. | |||
There was a problem hiding this comment.
I know this is an open topic but I'm cautious about adding 'see the X topic' when 'see X' is the dominant style and I'm not sure we want to switch this...just a note here, this isn't a biggie
There was a problem hiding this comment.
That would make this sentence: "For further information on Cloud Standard clusters and their limits, see Cloud Standard Edition."
I think that is less clear than: "For further information on Cloud Standard clusters and their limits, see the Cloud Standard Edition topic."
There was a problem hiding this comment.
Yes, but no-one will see it as above i.e. the Cloud Standard Edition text will be highlighted in blue.
I did have a quick look at MS and Google and they both follow this standard. I'm not sure it's worth the effort and deviation...
Hendy has confirmed that she will rename this file, so links are now updated to match
| @@ -93,6 +93,6 @@ image:postgres_inbound_rules.png[Inbound rules for a postgreSQL database instanc | |||
| == Related Resources | |||
|
|
|||
| - xref:hazelcast:sql:sql-statements.adoc[SQL Statements] | |||
| - xref:tutorials:ROOT:sql-on-viridian.adoc[SQL Basics on Viridian (Stock Ticker)] | |||
| - xref:tutorials:ROOT:sql-on-viridian.adoc[SQL Basics on Cloud (Stock Ticker)] | |||
There was a problem hiding this comment.
| - xref:tutorials:ROOT:sql-on-viridian.adoc[SQL Basics on Cloud (Stock Ticker)] | |
| - xref:tutorials:ROOT:sql_stock_ticker_cloud.adoc[SQL Basics on Cloud (Stock Ticker)] |
There was a problem hiding this comment.
Seems resolved, I updated the dead links though
@rebekah-lawrence
catching file name change
…dian' into DOCS-772_Update_nonvariable_Viridian
|
Thanks for catching the Eugene |
Catching instances of Viridian in the cloud repo that are not covered by the variable update