Update 'hazelcast.diagnostics.memberinfo.period.seconds' Property To Use 'seconds' In Plural #1512
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use 'seconds' in plural.
|
|
✅ Deploy Preview for hardcore-allen-f5257d ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
oliverhowell
added
the
backport to all versions
oliverhowell
approved these changes
Feb 3, 2025
This was referenced Feb 3, 2025
oliverhowell
pushed a commit
that referenced
this pull request
Feb 3, 2025
…Use 'seconds' In Plural [v/5.3] (#1517) Backport of #1512 In the current documentation, the name of the property in question is as follows: ```bash hazelcast.diagnostics.memberinfo.period.second ``` This name exists in two places: * [Configuration of the `HazelcastInstance` diagnostics plugin](https://docs.hazelcast.com/hazelcast/5.5/maintain-cluster/monitoring#hazelcastinstance) * [System properties reference](https://docs.hazelcast.com/hazelcast/5.5/system-properties#hide-nav) In Hazelcast Platform's source code, however, it's called `hazelcast.diagnostics.memberinfo.period.seconds`, see [MemberHazelcastInstanceInfoPlugin.java](https://github.com/hazelcast/hazelcast/blob/7b365b48eea173c322e895da552517e693f29134/hazelcast/src/main/java/com/hazelcast/internal/diagnostics/MemberHazelcastInstanceInfoPlugin.java#L43). This PR updates the two aforementioned occurrences, so they correspond to the name of the property in the source code. Co-authored-by: AntsInMyEy3sJohnson <[email protected]>
oliverhowell
pushed a commit
that referenced
this pull request
Feb 3, 2025
…Use 'seconds' In Plural [v/5.5] (#1519) Backport of #1512 In the current documentation, the name of the property in question is as follows: ```bash hazelcast.diagnostics.memberinfo.period.second ``` This name exists in two places: * [Configuration of the `HazelcastInstance` diagnostics plugin](https://docs.hazelcast.com/hazelcast/5.5/maintain-cluster/monitoring#hazelcastinstance) * [System properties reference](https://docs.hazelcast.com/hazelcast/5.5/system-properties#hide-nav) In Hazelcast Platform's source code, however, it's called `hazelcast.diagnostics.memberinfo.period.seconds`, see [MemberHazelcastInstanceInfoPlugin.java](https://github.com/hazelcast/hazelcast/blob/7b365b48eea173c322e895da552517e693f29134/hazelcast/src/main/java/com/hazelcast/internal/diagnostics/MemberHazelcastInstanceInfoPlugin.java#L43). This PR updates the two aforementioned occurrences, so they correspond to the name of the property in the source code. Co-authored-by: AntsInMyEy3sJohnson <[email protected]>
|
@oliverhowell My pleasure! |
oliverhowell
pushed a commit
that referenced
this pull request
Feb 3, 2025
…Use 'seconds' In Plural [v/5.4] (#1518) Backport of #1512 In the current documentation, the name of the property in question is as follows: ```bash hazelcast.diagnostics.memberinfo.period.second ``` This name exists in two places: * [Configuration of the `HazelcastInstance` diagnostics plugin](https://docs.hazelcast.com/hazelcast/5.5/maintain-cluster/monitoring#hazelcastinstance) * [System properties reference](https://docs.hazelcast.com/hazelcast/5.5/system-properties#hide-nav) In Hazelcast Platform's source code, however, it's called `hazelcast.diagnostics.memberinfo.period.seconds`, see [MemberHazelcastInstanceInfoPlugin.java](https://github.com/hazelcast/hazelcast/blob/7b365b48eea173c322e895da552517e693f29134/hazelcast/src/main/java/com/hazelcast/internal/diagnostics/MemberHazelcastInstanceInfoPlugin.java#L43). This PR updates the two aforementioned occurrences, so they correspond to the name of the property in the source code. Co-authored-by: AntsInMyEy3sJohnson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current documentation, the name of the property in question is as follows:
This name exists in two places:
HazelcastInstancediagnostics pluginIn Hazelcast Platform's source code, however, it's called
hazelcast.diagnostics.memberinfo.period.seconds, see MemberHazelcastInstanceInfoPlugin.java.This PR updates the two aforementioned occurrences, so they correspond to the name of the property in the source code.