Re-write authentication of Flow [HZX-219]. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
userMuratt
changed the title
promanenko
reviewed
Sep 2, 2024
promanenko
reviewed
Sep 2, 2024
pollett
reviewed
Sep 3, 2024
|
|
||
| (Author's note- some link in table are broken - please confirm what these should be) | ||
| //// | ||
| Internal notes to Hazelcast employees: |
There was a problem hiding this comment.
What do you think about having the docker compose examples here, versus a reference out to
https://github.com/hazelcast/hazelcast-flow-docker-compose/blob/main/docker-compose-idp.yml
Very cautious about how many different places we have docker compose files if we ever make any config changes!
(Also, are you able to take a look over that file and make sure it mirrors the correct config here 🙏 )
There was a problem hiding this comment.
yes, i think centralising docker compose files makes sense. this should be done.
|
#12 is opened to replace this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.