Skip to content

Commit

Permalink
Add suggestion from reviewer #462
Browse files Browse the repository at this point in the history
  • Loading branch information
TobiasNx committed Jun 4, 2024
1 parent 780d575 commit decd84f
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion README.textile
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ The transformation is triggered when the application starts but it can also be s

If you run the transformation with the full data (see above for downloads), the application will download additional updates for the Sigel data.

Thus, you will have specify one parameters in @conf/application.conf@ : the date from which the updates start (usually the date of the base dump creation, e.g. 2013-06-01).
Thus, you will have specify one parameters in @conf/application.conf@ : the date from which the updates start (usually the date of the base dump creation, e.g. 2024-02-01).

You can run the transformation of the full data using the following command:

Expand Down
6 changes: 3 additions & 3 deletions app/transformation/TransformAll.java
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,10 @@ public class TransformAll {
* @throws IOException If dump and temp files cannot be read
*/
public static void process(final String startOfUpdates,
String outputPath, final String geoServer, final String wikidataLookupFilename) throws IOException {
String outputPath, final String geoServer, final String wikidataLookupFilename) throws IOException {
String dbsOutput = outputPath + "-dbs";
String sigelBulkOutput = outputPath + "-sigelBulk";
String sigelUpdatesOutput = outputPath + "-sigelUpdates";
String sigelUpdatesOutput = outputPath + "-sigelUpdates";
TransformSigel.processBulk(sigelBulkOutput, geoServer, wikidataLookupFilename); //Start processing Sigel pica binary bulk.
if (startOfUpdates != "") { // exclude updates for the tests, which set startOfUpdates to ""
TransformSigel.processUpdates(startOfUpdates, sigelUpdatesOutput, geoServer, wikidataLookupFilename); //Start process Sigel Pica XML Updates via OAI-PMH.
Expand All @@ -65,7 +65,7 @@ public static void process(final String startOfUpdates,
writeAll(sigelBulkOutput, resultWriter);
if (startOfUpdates != "") { // exclude updates for the tests, which set startOfUpdates to ""
writeAll(sigelUpdatesOutput, resultWriter);
}
}
}
}

Expand Down
2 changes: 1 addition & 1 deletion app/transformation/TransformSigel.java
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ static void processUpdates(String startOfUpdates,
encodeJson.setPrettyPrinting(true);
ObjectWriter objectWriter = new ObjectWriter<>(outputPath);
objectWriter.setAppendIfFileExists(true);
sigelOaiPmhUpdates//
sigelOaiPmhUpdates//
.setReceiver(new XmlDecoder())//
.setReceiver(new PicaXmlHandler())//
.setReceiver(new Metafix("conf/fix-sigel.fix")) // Preprocess Sigel-Data and fix skips all records that have no "inr" and "isil"
Expand Down

0 comments on commit decd84f

Please sign in to comment.