Fix name for dbsId in wikidata lookups #383 #499
Merged
+17
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to inconsistent naming the lookup failed. This commit fixes the lookup
|
I don't know if this fixes the problem. |
|
You added this file via cron job: #498 and can create it with the bash script that you mentioned in the README.md Also test/transformation/output/enriched-test.json-dbs shows already the wanted outcome. To improve the testing of new features and bug fixes, #460 would help since the elastic search bulk is not very helpful to highlight the changes. |
|
Right ! I forgot already about the script creating the needed data. So atm. , first time it's rolled out, one has to execute the script (like mentioned in the README). Otherwise a deployment is not possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to inconsistent naming the lookup failed. This commit fixes the lookup. Related to #383