Add missing language tag #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, I do not see why the checks fail and am not sure whether it actually has anything to do with my change. |
|
You probably didn't branch off the current main branch (which contains the fix for the build error). |
..when automatically creating the classification to avoid errors in SkoHub shape validation process.
acka47
force-pushed
the
addMissingLanguageTag
branch
from
05fd946 to
e615b5d
Compare
Thanks, I pulled the changes and force-pushed (sorry) into this branch. |
fsteeg
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
..when automatically creating the classification to avoid errors in SkoHub shape validation process.
See failing test at https://github.com/hbz/lobid-vocabs/actions/runs/12633659256/job/35199950424 and me manually adding the tag in hbz/lobid-vocabs@f271dc5 (and also hbz/lobid-vocabs@79b0bad)