fix useEffect warnings

hcp-uw · May 1, 2024 · 4878bd1 · 4878bd1
1 parent 9be5182
commit 4878bd1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 12 deletions.
diff --git a/client/src/pages/Profile.tsx b/client/src/pages/Profile.tsx
@@ -117,7 +117,7 @@ export function EditProfile() {
   useEffect(() => {
     if (!user) return;
     setImage(user.imageUrl);
-  }, [isLoaded]);
+  }, [isLoaded, user]);
 
   if (!isSignedIn) return <div>must be logged in</div>;
 

diff --git a/client/src/pages/Project.tsx b/client/src/pages/Project.tsx
@@ -75,14 +75,6 @@ export default function Project() {
     }
   }
 
-  const requestData = trpc.memberships.getAllPendingRequests.useQuery(
-    projectId ?? '',
-  );
-
-  if (requestData.data != undefined) {
-    console.log(requestData.data);
-  }
-
   const leaveProjectMutation = trpc.memberships.leaveProject.useMutation({
     onSuccess() {
       console.log('Left Project');
@@ -523,12 +515,10 @@ export function ProjectPostsLayout() {
 
   useEffect(() => {
     if (postId === undefined && data) {
-      console.log('here');
-
       if (data.length === 0) return;
       navigate(`/${projectId}/posts/${data[0].id}`);
     }
-  }, []);
+  }, [data, navigate, postId, projectId]);
 
   if (isLoading) return <div>loading posts</div>;