Fix: GitHub workflow script injection #86
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I'm Joyce from Google's Open Source Security Team(GOSST) and I'm here to suggest this small fix to prevent from script injection attacks through your GitHub workflows.
You can see further explanation about this kind of threat in this blogpost Keeping your GitHub Actions and workflows secure Part 2: Untrusted input.
Any questions, let me know!
Summary of changes
github.head_ref
to an envvar to prevent from potential script injection.PR checklist for schema changes
Not changing any schemas
docs/source/conf.py
andcommon/namespace.yaml
to the next version with the suffix "-alpha"docs/source/hdmf_common_release_notes.rst
and/ordocs/source/hdmf_experimental_release_notes.rst