Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the EmbeddedServerHelper more dynamic by allowing more parameters in the constructor #230

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

ghost
Copy link

@ghost ghost commented Jul 6, 2011

Hi all,
as sent over hector-users, I extendend the EmbeddedServerHelper to take more arguements and make use of a template .yaml file which gets filled with correct values at setup(..) time.
Also take an argument for an external log4j file which gets copied along into the folder of choice.

I kept both a the EmbeddedServerHelper(String yamlFile) and EmbeddedServerHelper() constructors with correct default values to act as a drop-in replacement. I ran all the available tests, so it should work.

Felipe

@ghost
Copy link
Author

ghost commented Aug 24, 2011

I have created a config object which can be passed onto the EmbeddedServerHelper constructor.
If the constructor is called without any arguments, it behaves like the old one.
EmbeddedServerConfigurator has a special method called createFromYaml(String yamlPath) which returns a matching ESC for the given configuration.
I have also added some tests for the different constructors.

@ghost ghost closed this Aug 24, 2011
@ghost ghost reopened this Aug 24, 2011
@ghost
Copy link
Author

ghost commented Aug 24, 2011

I wrote a EmbeddedServerConfigurator object which is used to configure the EmbeddedServerHelper.
When no arguments are passed, the EmbeddedServerHelper behaves just like the old one.
EmbeddedServerConfigurator has a neat method called createFromYaml(...) which turns a Yaml file into an ESC object.

Other than that I have cleaned up the code a bit and added some tests.

@jsevellec
Copy link

This feature is very interesting especially to use it in cassandra-unit

@ghost ghost closed this Aug 27, 2011
@ghost
Copy link
Author

ghost commented Aug 27, 2011

Some files are in the wrong place. I'll close this request and open up a new one.

@ghost ghost reopened this Aug 29, 2011
@patricioe
Copy link
Collaborator

What's the status of this ? Sean ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants