Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #454 ColumnFamilyIterator #456

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

bharatendra
Copy link

Added ColumnFamilyIterator and a test case for the same.

@bharatendra
Copy link
Author

I Updated the ColumnFamilyIterator to use ColumnSliceIterator and KeyIterator internally. Now the code is much simpler.

I noticed that I can not instantiate the ColumnSliceIterator using null value for finish parameter. For ex:
new ColumnSliceIterator(sliceQuery, null, null, false, maxColumnsCount). It is throwing NP exception.
I need to specify
N finish = null and use new ColumnSliceIterator(sliceQuery, null, finish, false, maxColumnsCount)

The key iterator may not return keys if all the columns are deleted in a row. May be it is useful to allow option to set keysonly to use setReturnKeysOnly() internally

Also the ColumnSliceIterator;:hasNext() can throw NP exception if column family has on columns or a row contains no columns. I will test this and update you later.

@dserdyuk
Copy link

Any information on which release is going to include these changes ?
thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants