Implement rate limiter on reset password #5103
Conversation
requirements.txt
Outdated
| @@ -28,10 +28,11 @@ turtlethread>=0.0.6 | |||
| pygame==2.1.2 | |||
| pre-commit==2.20.0 | |||
| babel==2.14.0 | |||
| jinja-partials==0.1.1 | |||
| jinja-partials==0.1.1clea | |||
There was a problem hiding this comment.
I suspect this is a typo @TiBiBa? Did you mean just to leave it at 0.1.1 or is there another version needed?
There was a problem hiding this comment.
I think this is a typo, will look into this. We should also decide on a nice test case, but that might be easy to fix on Alpha.
|
Here is another old left over PR from the hackathon that could be either closed or finished? |
| # Implement the rate limiter | ||
| limiter = Limiter( | ||
| get_remote_address, | ||
| storage_uri="memory://", |
There was a problem hiding this comment.
I managed to get the limiter working, but for us to make this really work on production we'd have to use a persistent storage solution, like memcached, redis or MongoDB. Now, all of these solutions come at a cost, since as far as I can tell, we'd need to pay a cloud provider for this (e.g; Memcached Cloud), with varying costs. @TiBiBa Did you have something in mind when opening this PR about this, do you know a way to fire a memcached server on Heroky without incurring on costs?
jpelay
added
the
backend
This PR fixes #5102.