Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚚 Fix extra newlines in co-authors #5866

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

jotare
Copy link
Contributor

@jotare jotare commented Oct 21, 2024

Fixes a small issue with #5852
Jinja template adds a new line after each iteration, this makes Github only recognize the last co-author. This error can be seen here: d1109b1

Adding -% to the template removes this extra newlines

@jotare
Copy link
Contributor Author

jotare commented Oct 21, 2024

@Felienne a small fix on the co-authors. It's always hard to get a CI change on the first try :)

@Felienne
Copy link
Member

@Felienne a small fix on the co-authors. It's always hard to get a CI change on the first try :)

Yes it is so annoying these things can't be tested easily!

Copy link
Contributor

mergify bot commented Oct 21, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 909422c into hedyorg:main Oct 21, 2024
10 checks passed
@jotare jotare deleted the fix-extra-newlines-in-co-authors branch October 21, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants