Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪲 Improve error message for missing list in add-to and remove-from commands #5872

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

boryanagoncharenko
Copy link
Collaborator

@boryanagoncharenko boryanagoncharenko commented Oct 24, 2024

This PR adds a specific error message when the user forgot to add a list at the end of the add-to and remove-from commands. Previously, we displayed a generic error that something is off with the line:
We detected that Add is being used on line 3 which is not allowed. Can you try looking for a missing or an extra character on your code?

Now we changed it to: We detected that part of the code seems to be missing from the Add on line 3. Can you try adding the what's missing

Fixes #5871

How to test
Go to level 3 and execute the following commands:

houses is Gryffindor, Hufflepuf, Ravenclaw, Slytherin
dislike is Slytherin
remove dislike from

and

houses is Gryffindor, Hufflepuf, Ravenclaw, Slytherin
dislike is Slytherin
remove dislike

Check that you agree with the error messages.

Copy link
Member

@jpelay jpelay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! It works perfectly! Just one tiny comment: can you fix the writing of this message?

image

"Can you try adding the what's missing" sounds a bit weird to me.

@boryanagoncharenko
Copy link
Collaborator Author

Hello! It works perfectly! Just one tiny comment: can you fix the writing of this message?

image

"Can you try adding the what's missing" sounds a bit weird to me.

Thanks for the feedback. I did not notice the error at all. I removed the the from the sentence.

Copy link
Member

@jpelay jpelay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's perfect now! Thanks!

Copy link
Contributor

mergify bot commented Oct 24, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 30fa5f8 into main Oct 24, 2024
11 checks passed
@mergify mergify bot deleted the errors_5871 branch October 24, 2024 20:23
Copy link
Contributor

mergify bot commented Oct 24, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🪲 Improve error messages for add-to and remove-from commands
2 participants