Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪲 Move the modal close button to top right/left corner #5906

Merged
merged 3 commits into from
Nov 7, 2024
Merged

🪲 Move the modal close button to top right/left corner #5906

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3b5ca0e
Move the modal close button to top right/left corner #5887
boryanagoncharenko Oct 31, 2024
d6ab297
change pointer to cursor when hovering over close button
jpelay Nov 7, 2024
c3afb4d
Merge branch 'main' into modals_5887
mergify[bot] Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions templates/layout.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,10 +215,12 @@ <h2>{{ _('levels')|capitalize }}</h2>
</div>
</div>
<div id="modal_alert" class="z-50 fixed hidden" role="alert" style="top: 10%; left: 50%; transform: translate(-50%, -50%);">
<div id="modal_alert_container" data-cy="modal_alert_container" class="mx-auto text-center bg-green-100 border-green-400 text-green-700 border rounded px-4 py-3">
<span id="modal_alert_title" class="block sm:inline"></span>
<div id="modal_alert_container" data-cy="modal_alert_container"
class="mx-auto text-center bg-green-100 border-green-400 text-green-700 border rounded px-7 py-2">
<svg class="absolute top-2 end-1 h-6 w-6 fill-current text-green-500 block sm:inline cursor-pointer"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a class so that the cursor changes to pointer when you hover over it, hope you don't mind!

id="modal_alert_button"
xmlns="http://www.w3.org/2000/svg" viewBox="0 0 20 20"><title>Close</title><path d="M14.348 14.849a1.2 1.2 0 0 1-1.697 0L10 11.819l-2.651 3.029a1.2 1.2 0 1 1-1.697-1.697l2.758-3.15-2.759-3.152a1.2 1.2 0 1 1 1.697-1.697L10 8.183l2.651-3.031a1.2 1.2 0 1 1 1.697 1.697l-2.758 3.152 2.758 3.15a1.2 1.2 0 0 1 0 1.698z"/></svg>
<span id="modal_alert_text" data-cy="modal_alert_text" class="block sm:inline"></span>
<svg class="fill-current h-6 w-6 text-green-500 block sm:inline" id="modal_alert_button" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 20 20"><title>Close</title><path d="M14.348 14.849a1.2 1.2 0 0 1-1.697 0L10 11.819l-2.651 3.029a1.2 1.2 0 1 1-1.697-1.697l2.758-3.15-2.759-3.152a1.2 1.2 0 1 1 1.697-1.697L10 8.183l2.651-3.031a1.2 1.2 0 1 1 1.697 1.697l-2.758 3.152 2.758 3.15a1.2 1.2 0 0 1 0 1.698z"/></svg>
</div>
</div>

Expand Down
Loading