Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

looser dependency versions #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Orycterope
Copy link

@Orycterope Orycterope commented Jun 4, 2021

Removes the '~' from dependency versions.

The '~' operator is much more restrictive than the default caret operator.

I had conflicts on the memchr version because of your crate, even though I wasn' t even compiling it. I'm depending on heim while compiling for windows, and heim depends on your crate only when compiling for macos, but because of the way cargo resolves its dependencies, this still caused dependency resolution to fail.

@roblabla
Copy link

Bump. The ~ operator should really never be used in libraries, as it causes much pain in the dependency resolution process.

@roblabla
Copy link

Bump. This is still a problem.

@AgeManning
Copy link

bump also

@kotx
Copy link

kotx commented Jan 5, 2022

Bump

@kotx kotx mentioned this pull request Jan 5, 2022
@tranzystorekk
Copy link

Bump, memchr "~2.3.0" conflicts with the newly released clap 3.0 when used along this crate

@IniterWorker
Copy link

IniterWorker commented Apr 8, 2022

heim-rs/heim seems to move on with the ^ in the lastest rc.

  • Is it a mater of tight design @svartalf with memchr?
  • memchr requirement comes from regex crate 1.5.4+ CVE-2022-24713.

@jeremy-prater
Copy link

Bump for webrtc-0.4.0

error: failed to select a version for `memchr`.
    ... required by package `darwin-libproc v0.2.0`
    ... which satisfies dependency `darwin-libproc = "^0.2.0"` of package `simple-process-stats v1.0.0`
    ... which satisfies dependency `simple-process-stats = "^1.0.0"` of package `watchman v0.1.0 (/Users/RPM/src/watchman)`
versions that meet the requirements `~2.3` are: 2.3.4, 2.3.3, 2.3.2, 2.3.0

all possible versions conflict with previously selected packages.

  previously selected package `memchr v2.4.0`
    ... which satisfies dependency `memchr = "^2.4.0"` of package `aho-corasick v0.7.18`
    ... which satisfies dependency `aho-corasick = "^0.7.18"` of package `regex v1.5.4`
    ... which satisfies dependency `regex = "^1.5.4"` of package `webrtc v0.4.0`
    ... which satisfies dependency `webrtc = "^0.4.0"` of package `watchman v0.1.0 (/Users/RPM/src/watchman)`

failed to select a version for `memchr` which could resolve this conflict

jeremy-prater added a commit to jeremy-prater/simple-process-stats that referenced this pull request Apr 20, 2022
Change upstream darwin-libproc to a fixed version
See heim-rs/darwin-libproc#3
@mjpieters
Copy link

This is a blocker for me to using this crate, too many packages conflict with darwin-libproc; e.g. rev_buf_reader v0.3.0:

error: failed to select a version for `memchr`.
    ... required by package `darwin-libproc v0.2.0`
    ... which satisfies dependency `darwin-libproc = "^0.2.0"` of package `pueue-lib v0.21.0 (/.../pueue/lib)`
    ... which satisfies path dependency `pueue-lib` (locked to 0.21.0) of package `pueue v2.1.0 (/.../pueue)`
versions that meet the requirements `~2.3` are: 2.3.4, 2.3.3, 2.3.2, 2.3.0

all possible versions conflict with previously selected packages.

  previously selected package `memchr v2.4.1`
    ... which satisfies dependency `memchr = "^2.4.1"` of package `rev_buf_reader v0.3.0`
    ... which satisfies dependency `rev_buf_reader = "^0.3"` of package `pueue-lib v0.21.0 (/.../pueue/lib)`
    ... which satisfies path dependency `pueue-lib` (locked to 0.21.0) of package `pueue v2.1.0 (/.../pueue)`

failed to select a version for `memchr` which could resolve this conflict

@Antti
Copy link

Antti commented Jul 21, 2023

Any updates on this?

In the meantime, we can solve the issue by adding this to your Cargo.toml

[patch.crates-io]
darwin-libproc = { git="https://github.com/Orycterope/darwin-libproc.git", branch="dependencies_versions" }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants